Fix: Failing integration tests #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NunoAlexandre
added a commit
that referenced
this pull request
May 31, 2023
* Diener 0.9.38 + cargo update * fix import * wip on GeneralKey and xcm configs * fixup * Update docker images to 0.9.38 * Fix dup dependencies * wip * Add missing features to root, dev, connectors * wip * Add getrandom js * Fix missing features * cargo update * cargo update * tmp: Add std features to integration-tests * Fix all pallet's missing features * Fix missing features of all libs * wip * wip * fix: remove unused rand from integration tests * fix: remove unused dep * fix: missing std feat in pool-system * chore: revert rust nightly version to latest supported * cargo update * Fix connectors weight issue * xcm updates * pallet_authorship::Config updates * wip: Update xcm Trader * Update xtokens Config * Update more configs * Dry AccountIdToMultiLocation * Weights v2 updates * Use ConvertedConcreteId instead ConvertedConcreteAssetId is now deprecated * wip * wip * fmt * Update pallet_transaction_payment_rpc_runtime_api::TransactionPaymentApi * wip * wip * Update impl xcm_executor::Config * Fix imports * wip * wip * Fix node, service and evm issues * fmt * Fix integration tests compilation errors * wip: Fix xcm transfer tests * wip: Fix xcm tests * Fix transfer_ausd_to_centrifuge * fix xcm tests * fmt * fixup * clippy fix * Update xcm v1 -> v3 in some tests * more fixes * fmt * Add note on failing test * Re-enable all other e2e tests * fmt * fixup * Drop comments * Test handling of XCM v2 multilocations in storage * fmt * fixup * fixup * Fix from_xcm_versioned_address_works * Revive and fix kusama/currency_id_convert tests * xcm: Simplify CurrencyIdConvert * fmt * fmt * Address @wischli's review comments * Fix all missing cargo features * Fix cargo doc by bumping toolchain The issue we are experiencing now apparently by bumping to polkadot 0.9.38 seems to have been fixed bacm in Nov 2022 but our current toolchain version didn't yet include it. So we bump the toolchain version. Working well locally. * fmt * clippy * Fix: Failing integration tests (#1370) * deps: Update RUST_TOOLCHAIN to nightly-2023-02-07 * Document general_key fn * Fix clippy * fmt --------- Co-authored-by: William Freudenberger <w.freude@icloud.com> Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de> Co-authored-by: cdamian <17934949+cdamian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The logic previously fetched events at block zero, which where simply not existing as not populated. Substrate changed to panicking now, when somebody does this. This change fetches events only starting at block 1.