New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connectors: Wrapped token lookup #1393
Conversation
We also add migragitons to set the appropriate value depending on the type of currency.
aeb50a6
to
742ceda
Compare
742ceda
to
f42a6e6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Added my two cents on the asset registry question and I feel like we are missing at least a Moonbeam derivation?
357b730
to
82b9737
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just wanted to highlight that we could imlement this purely on the connectors level without moving to the runtime level if we drop the pallet instance. But no blocker.
Part 2/2 of #1350
Changes
Add
ConnectorsWrappedToken
, an enum type representing the Connectors Wrapped tokens we handle. At this moment, that's only EVM tokens. As described in the docs of that type, in the future it might be others such as Cosmos or Avalanche.We implement conversion between
ConnectorsWrappedToken
andMultiLocation
Usage
When registering a
ConnectorsWrappedToken
in theOrmlAssetRegistry
, we define theMetadata.location
asConnectorsWrappedTokenConvert<ConnectorsPalletIndex>>::convert(connectors_wrapped_token)
;In the connectors pallet we add a new type:
add_currency
extrinsic of the connectors pallet, we will roughly do: