Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loans: Avoid check price id when creating loans #1417

Merged
merged 2 commits into from Jun 27, 2023
Merged

Loans: Avoid check price id when creating loans #1417

merged 2 commits into from Jun 27, 2023

Conversation

lemunozm
Copy link
Contributor

Description

From slack thread

@lemunozm lemunozm added Q1-easy Can be done by primarily duplicating and adapting code. I3-annoyance The code behaves as expected, but "expected" is an issue. D0-ready Pull request can be merged without special precaution and notification. P7-asap Issue should be addressed in the next days. labels Jun 27, 2023
@lemunozm lemunozm self-assigned this Jun 27, 2023
hieronx
hieronx previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@hieronx hieronx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick, as always :)

@lemunozm lemunozm requested a review from hieronx June 27, 2023 07:11
@lemunozm lemunozm enabled auto-merge (squash) June 27, 2023 07:11
@lemunozm lemunozm merged commit c5d9682 into main Jun 27, 2023
11 checks passed
@lemunozm lemunozm deleted the loans/creation-price-id-no-check branch June 27, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hieronx hieronx hieronx approved these changes

Assignees

@lemunozm lemunozm

Labels
D0-ready Pull request can be merged without special precaution and notification. I3-annoyance The code behaves as expected, but "expected" is an issue. P7-asap Issue should be addressed in the next days. Q1-easy Can be done by primarily duplicating and adapting code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lemunozm @hieronx