Loans: maturity extension support #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
the
D8-migration
lemunozm
commented
Jul 6, 2023
hieronx
reviewed
Jul 7, 2023
hieronx
previously approved these changes
Jul 7, 2023
|
I've rebased this already approved by Jeroen, it would be awesome if you could give a re-approve it @mustermeiszer 🙌🏻 |
|
@lemunozm does this need a migration? Because I can not spot the migration code ^^ Just am worried we forget about it if we add it later. |
lemunozm
commented
Jul 11, 2023
Comment on lines
+96
to
102
| Fixed { | ||
| /// Secs when maturity ends | ||
| date: Moment, | ||
| /// Extension in secs, without special permissions | ||
| extension: Moment, | ||
| }, | ||
| } |
There was a problem hiding this comment.
Here is the migration. But it needs migration "theoretically". Right now we can purge all pallet-loans storage. It only requires a migration if it is used before we can deploy these changes. The same applies to all pending PRs
There was a problem hiding this comment.
Ah ok, I read you wrong 😆, I pointed to the code that causes the migration. No, there is no migration done, but should not be done by now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1405
Changes and Descriptions
extensionfield toMaturity::FixedMaturityExtension