Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nuke migration for loans & interest-accrual #1506

Merged
merged 2 commits into from Aug 18, 2023

Conversation

lemunozm
Copy link
Contributor

Description

Fixes #1461

Changes and Descriptions

  • Nuke migration for pallet-loans
    • Tested in altair and centrifuge, and currently, there is nothing there. Should we then add the migration? I think it makes sense to remove anything anyone can add these days there until the next release.
  • Nuke migration for interest-accrual
    • I removed the old StorageVersion storage in order to use the new one.
    • Found some rates that we can delete.

## Tests

altair

Comand:

RUST_LOG=runtime=trace,try-runtime::cli=trace,executor=trace cargo run --release --features try-runtime try-runtime --runtime target/release/wbuild/altair-runtime/altair_runtime.wasm --chain centrifuge on-runtime-upgrade live --uri wss://fullnode.altair.centrifuge.io:443

Output:

2023-08-17 16:38:24.490  INFO main runtime_common::migrations::nuke: Nuke-Loans: nuking pallet...
2023-08-17 16:38:24.490  INFO main runtime_common::migrations::nuke: Nuke-Loans: storage cleared successful
2023-08-17 16:38:24.490  INFO main runtime_common::migrations::nuke: Nuke-Loans: iteration result. backend: 1 unique: 1 loops: 1
2023-08-17 16:38:24.490  INFO main runtime_common::migrations::nuke: Nuke-InterestAccrual: nuking pallet...
2023-08-17 16:38:24.490  INFO main runtime_common::migrations::nuke: Nuke-InterestAccrual: storage cleared successful
2023-08-17 16:38:24.490  INFO main runtime_common::migrations::nuke: Nuke-InterestAccrual: iteration result. backend: 3 unique: 3 loops: 3

centrifuge

Command:

RUST_LOG=runtime=trace,try-runtime::cli=trace,executor=trace cargo run --release --features try-runtime try-runtime --runtime target/release/wbuild/centrifuge-runtime/centrifuge_runtime.wasm --chain centrifuge on-runtime-upgrade live --uri wss://fullnode.centrifuge.io:443

Output:

2023-08-17 12:57:55.948  INFO main runtime_common::migrations::nuke: Nuke-Loans: nuking pallet...
2023-08-17 12:57:55.948  INFO main runtime_common::migrations::nuke: Nuke-Loans: storage cleared successful
2023-08-17 12:57:55.948  INFO main runtime_common::migrations::nuke: Nuke-Loans: iteration result. backend: 1 unique: 1 loops: 1
2023-08-17 12:57:55.948  INFO main runtime_common::migrations::nuke: Nuke-InterestAccrual: nuking pallet...
2023-08-17 12:57:55.948  INFO main runtime_common::migrations::nuke: Nuke-InterestAccrual: storage cleared successful
2023-08-17 12:57:55.948  INFO main runtime_common::migrations::nuke: Nuke-InterestAccrual: iteration result. backend: 2 unique: 2 loops: 2

@lemunozm lemunozm added I9-release A specific release. P5-soon Issue should be addressed soon. crcl-protocol Circle protocol related. D8-migration Pull request touches storage and needs migration code. labels Aug 17, 2023
@lemunozm lemunozm self-assigned this Aug 17, 2023
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lemunozm lemunozm merged commit dd5d430 into main Aug 18, 2023
11 checks passed
@lemunozm lemunozm deleted the nuke-loans-related-pallets branch August 18, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crcl-protocol Circle protocol related. D8-migration Pull request touches storage and needs migration code. I9-release A specific release. P5-soon Issue should be addressed soon.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loans: prepare Loans for release
3 participants