Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: nuke migrations #1513

Merged
merged 2 commits into from Aug 22, 2023
Merged

fix: nuke migrations #1513

merged 2 commits into from Aug 22, 2023

Conversation

mustermeiszer
Copy link
Collaborator

Description

Nuke migrations check the storage for a certain prefix. As the on_chain_strorage_version is also stored under the prefix, we need to ommit this specific key if we check whether the storage was cleared successfully.

@mustermeiszer mustermeiszer added the D0-ready Pull request can be merged without special precaution and notification. label Aug 22, 2023
wischli
wischli approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Happy that the loop is only necessary for the try-tuntime part.

@mustermeiszer
Copy link
Collaborator Author

Otherwise would be quite a blocker. Haha

NunoAlexandre
NunoAlexandre approved these changes Aug 22, 2023
View reviewed changes
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, did you test this locally building with the try-runtime,testnet-runtime features and then run try-runtime against Algol?

@mustermeiszer
Copy link
Collaborator Author

See logs I send on slack

@wischli wischli enabled auto-merge (squash) August 22, 2023 11:53
@NunoAlexandre
Copy link
Contributor

See logs I send on slack

yeah sorry I saw the PR first 👍

@hieronx hieronx disabled auto-merge August 22, 2023 13:02
@hieronx hieronx closed this Aug 22, 2023
@hieronx hieronx merged commit 4005544 into main Aug 22, 2023
11 checks passed
@NunoAlexandre NunoAlexandre deleted the fix/nuke branch August 22, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NunoAlexandre NunoAlexandre NunoAlexandre approved these changes

@wischli wischli wischli approved these changes

Assignees
No one assigned
Labels
D0-ready Pull request can be merged without special precaution and notification.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mustermeiszer @NunoAlexandre @wischli @hieronx