Add Liquidity Pools related pallets to centrifuge runtime #1523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdamian
force-pushed
the
feat/add-lp-to-centrifuge-runtime
branch
from
ebe4d1a
to
daad72a
Compare
cdamian
commented
Sep 1, 2023
cdamian
commented
Sep 1, 2023
cdamian
commented
Sep 1, 2023
cdamian
commented
Sep 1, 2023
cdamian
commented
Sep 1, 2023
runtime/centrifuge/src/lib.rs
Outdated
| parameter_types! { | ||
| // TODO(cdamian): is this correct? | ||
| // 1 DOT should be enough to cover for fees opening/accepting hrmp channels | ||
| pub MaxHrmpRelayFee: MultiAsset = (MultiLocation::parent(), 1_000_000_000_000u128).into(); |
There was a problem hiding this comment.
Are we OK with this value?
There was a problem hiding this comment.
AFAICT this is way too high: DOT has 10 decimals, so this value is actually 100 DOT.
There was a problem hiding this comment.
Should we go with 1 DOT or less?
cdamian
requested review from
mikiquantum,
mustermeiszer,
NunoAlexandre,
hieronx and
wischli
as code owners
cdamian
commented
Sep 1, 2023
cdamian
changed the title
lemunozm
reviewed
Sep 1, 2023
| type Permission = Permissions; | ||
| type PoolId = PoolId; | ||
| type PoolInspect = PoolSystem; | ||
| type Rate = Rate; |
There was a problem hiding this comment.
Very important here to change Rate by Quantity in case #1520 is finally merged
There was a problem hiding this comment.
OK, I'm not sure we wanna have that part of this release so let's keep this open until we decide that and then I'll adjust as needed.
Thank you for the catch @lemunozm! <3
wischli
reviewed
Sep 1, 2023
runtime/centrifuge/src/lib.rs
Outdated
| parameter_types! { | ||
| // TODO(cdamian): is this correct? | ||
| // 1 DOT should be enough to cover for fees opening/accepting hrmp channels | ||
| pub MaxHrmpRelayFee: MultiAsset = (MultiLocation::parent(), 1_000_000_000_000u128).into(); |
There was a problem hiding this comment.
AFAICT this is way too high: DOT has 10 decimals, so this value is actually 100 DOT.
runtime/centrifuge/src/lib.rs
Outdated
| type CurrencyId = CurrencyId; | ||
| type CurrencyIdToMultiLocation = xcm::CurrencyIdConvert; | ||
| type DerivativeAddressRegistrationOrigin = EnsureRootOr<HalfOfCouncil>; | ||
| type HrmpEncoder = moonbeam_relay_encoder::westend::WestendEncoder; |
There was a problem hiding this comment.
I am fairly sure we want to have the Westend encoder but the Polkadot one?!
Suggested change
| type HrmpEncoder = moonbeam_relay_encoder::westend::WestendEncoder; | |
| type HrmpEncoder = moonbeam_relay_encoder::polkadot::PolkadotEncoder; |
In case I am correct, we must also change the HRMP encoder for altair to moonbeam_relay_encoder::kusama::KusamaEncoder
There was a problem hiding this comment.
Good catch! We should take a dedicated look at pallet_xcm_transactor again. I have this as part of our release list. That we check the XCM setup. I am almost certain, that we currently do not allow to transfer tokens out from our chain ^^
There was a problem hiding this comment.
We should also add the axelar-gateway-precompile. I am using that one for the (source_chain, source_address) to DomainAddress conversion on the XCM level
There was a problem hiding this comment.
Added and updated the Centrifuge precompile as well. PTAL
cdamian
commented
Sep 1, 2023
cdamian
force-pushed
the
feat/add-lp-to-centrifuge-runtime
branch
from
aa89aef
to
61543a6
Compare
mustermeiszer
approved these changes
Sep 2, 2023
| @@ -62,7 +64,7 @@ use orml_traits::{currency::MutationHooks, parameter_type_with_key}; | |||
| use pallet_anchors::AnchorData; | |||
| pub use pallet_balances::Call as BalancesCall; | |||
| use pallet_collective::{EnsureMember, EnsureProportionAtLeast, EnsureProportionMoreThan}; | |||
| use pallet_ethereum::Transaction as EthereumTransaction; | |||
| use pallet_ethereum::Transaction as EthTransaction; | |||
There was a problem hiding this comment.
I would prefer that we just literally refer to it with the pull path instead of aliasing the import. That's also what we do on Altair. It's only referred to in 3 places so it's fine and we save the indirection.
There was a problem hiding this comment.
I did this because EthereumTransaction is how we reference the actual pallet-ethereum-transaction that we added.
cdamian
added a commit
that referenced
this pull request
Sep 4, 2023
* centrifuge: Add liquidity pools pallets to runtime * centrifuge: Add LP OutboundQueue wrapper to runtime * taplo: Obey * runtime: Move OutboundQueue import * centrifuge: Allow both root and half of council as admin origins for LP pallets * centrifuge: Add Axelar Gateway precompile * centrifuge: Use correct HRMP encoder, update HRMP fee to 1 DOT, use XCM V3 imports * centrifuge: Update error message for InboundQueue * clippy: Fix warnings * centrifuge: Rename outbound queue, fix migration import for orml asset registry
cdamian
added a commit
that referenced
this pull request
Sep 4, 2023
* centrifuge: Add liquidity pools pallets to runtime * centrifuge: Add LP OutboundQueue wrapper to runtime * taplo: Obey * runtime: Move OutboundQueue import * centrifuge: Allow both root and half of council as admin origins for LP pallets * centrifuge: Add Axelar Gateway precompile * centrifuge: Use correct HRMP encoder, update HRMP fee to 1 DOT, use XCM V3 imports * centrifuge: Update error message for InboundQueue * clippy: Fix warnings * centrifuge: Rename outbound queue, fix migration import for orml asset registry
mustermeiszer
added a commit
that referenced
this pull request
Sep 6, 2023
* wip xcm v3 asset-registry migrations * fix: xcm v3 altair, centrifuge * feat: add defensive SafeCallFilter for transact * clean up asset addition for catalyst & centrifuge * add Altair + Algol migration * Add Liquidity Pools related pallets to centrifuge runtime (#1523) * centrifuge: Add liquidity pools pallets to runtime * centrifuge: Add LP OutboundQueue wrapper to runtime * taplo: Obey * runtime: Move OutboundQueue import * centrifuge: Allow both root and half of council as admin origins for LP pallets * centrifuge: Add Axelar Gateway precompile * centrifuge: Use correct HRMP encoder, update HRMP fee to 1 DOT, use XCM V3 imports * centrifuge: Update error message for InboundQueue * clippy: Fix warnings * centrifuge: Rename outbound queue, fix migration import for orml asset registry * Upgrade1020 LP follow-ups (#1525) * centrifuge: Enable LP gateway XCM origin converter * centrifuge: Update LP pallet config to use Quantity for BalanceRatio * runtime: Update XCM origin converter, use Quantity in LP message, add OriginRecovery to LP gateway * feat: safe XCM version migration + extend SafeCallFilter (#1526) * fix: allow gateway process msg for xcm * feat: add safe xcm version migration * fix: Allow process_msg for xcm transact * refactor: remove spec_version check * refactor: stricter SafeCallFilter * Upgrade1020 LP follow-ups (#1525) * centrifuge: Enable LP gateway XCM origin converter * centrifuge: Update LP pallet config to use Quantity for BalanceRatio * runtime: Update XCM origin converter, use Quantity in LP message, add OriginRecovery to LP gateway * fix: rm OrderBook safe call cause missing * fix: OrderBook missing in both runtimes * fix: clippy --------- Co-authored-by: Cosmin Damian <17934949+cdamian@users.noreply.github.com> * Feat/upgrade1020 misc 1 (#1529) * fix: asset metadata xcm v3 migration cleanup other migrations (#1528) * fix: centrifuge asset migration * Apply suggestions from code review Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de> * chore: append cfg assets to catalyst * fix: asset registry migration improvements * feat: apply asset metadata migration to altair runtime * fix: cleanup altair/algol migrations * fix: less aggressive nuke pre-upgrade * fix: finalize migrations, add context * fix: clippy + cleanup imports * fix: native currency altair, algol * fix: Algol native currency name --------- Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de> * fmt * fixup * Upgrade1020 gateway changes (#1531) * gateway: Use BoundedVec instead of EVMChain enum * gateway: Add Sender type to LP gateway config * gateway: Rename EVM chain size const, emit event when submitting message, adjust gateway sender provider * Feat: upgrade1020 misc 2 (#1532) * feat: account ensuring origin * feat: bumb runtime version develpment * fix: allow council to control gatway on Altair based chains * fix: use EnsureSigned, make use of type and add admin * feat: overestimated weights for lp logic * fix: taplooo * fix: tests and comment * chore: bump weights for 1020 (#1533) * chore: update centrifuge, altair weights * feat: bump and improve dev weights * fix: transfer_allowlist weights * feat: normalize SafeCallFilter across runtimes * fix: native asset key in migration --------- Co-authored-by: William Freudenberger <w.freude@icloud.com> Co-authored-by: Cosmin Damian <17934949+cdamian@users.noreply.github.com> Co-authored-by: Frederik Gartenmeister <mustermeiszer@posteo.de> Co-authored-by: nuno <hi@nunoalexandre.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding the Liquidity Pools pallets to the centrifuge runtime.
Changes and Descriptions
InboundQueuethat triggers event with info (Runtime struct)OutboundQueuethat LPs consumesAddCurrency,UpdateMember,AddPool,AddTranche,UpdateTrancheTokenPrice)Checklist: