Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Centrifuge 1020 & Algol 1031 migrations #1534

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Sep 7, 2023

Description

Part of the release process is cleaning up past migrations. Since Altair still needs to be migrated, we have to keep the common/src/migrations/asset_registry_xcmv3.rs migration.

  • Removes all Centrifuge migrations as both Catalyst as well as Centrifuge have been upgraded
    • Bumps migration tuple to UpgradeCentrifuge1021
  • Removes Algol 1031 migrations and bumps migration tuple to UpgradeAltair1032

@wischli wischli self-assigned this Sep 7, 2023
@wischli wischli added the D0-ready Pull request can be merged without special precaution and notification. label Sep 7, 2023
Copy link
Contributor

@NunoAlexandre NunoAlexandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I would prefer to not merge this yet until Centrifuge is upgraded, shall we find some issue in this time in between and need to push some hotfix. We can also merge it an git revert it but that might bite our 🍑 .

wdyt?

@wischli
Copy link
Contributor Author

wischli commented Sep 7, 2023

LGTM but I would prefer to not merge this yet until Centrifuge is upgraded, shall we find some issue in this time in between and need to push some hotfix. We can also merge it an git revert it but that might bite our 🍑 .

IMO, a hotfix should always be built on top of the release head and then be merged into main. Otherwise your argument could also be applied new features which should be held back. It will be quite common that new features are merged into main while the Centrifuge upgrade is not close to being executed. Take the 0.10.27 as an example: We merged the 0.9.38 upgrade immediately after releasing.

@NunoAlexandre
Copy link
Contributor

LGTM but I would prefer to not merge this yet until Centrifuge is upgraded, shall we find some issue in this time in between and need to push some hotfix. We can also merge it an git revert it but that might bite our 🍑 .

IMO, a hotfix should always be built on top of the release head and then be merged into main. Otherwise your argument could also be applied new features which should be held back. It will be quite common that new features are merged into main while the Centrifuge upgrade is not close to being executed. Take the 0.10.27 as an example: We merged the 0.9.38 upgrade immediately after releasing.

I get your point! Adding new features doesn't affect the correctness of the storage like in this case but your suggestion to apply any hotfix deemed necessary on top of the release head is fine and suffices 👍

@wischli wischli enabled auto-merge (squash) September 7, 2023 18:53
@wischli wischli merged commit 8bf76cf into main Sep 8, 2023
11 checks passed
@NunoAlexandre NunoAlexandre deleted the chore/remove-1020-migrations branch September 8, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants