feat: encode source address correctly in gateway #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustermeiszer
requested review from
NunoAlexandre,
lemunozm,
wischli and
cdamian
as code owners
cdamian
reviewed
Sep 13, 2023
cdamian
reviewed
Sep 13, 2023
cdamian
previously approved these changes
Sep 13, 2023
mustermeiszer
added
the
D0-ready
cdamian
previously approved these changes
Sep 14, 2023
wischli
reviewed
Sep 14, 2023
| @@ -12,6 +12,7 @@ targets = ["x86_64-unknown-linux-gnu"] | |||
|
|
|||
| [dependencies] | |||
| codec = { package = "parity-scale-codec", version = "3.0.0", features = ["derive"], default-features = false } | |||
| hex = {version = "0.4.3", default-features = false } | |||
There was a problem hiding this comment.
CR: We are importing hex without std here but not enabling the std feature below.
Comment on lines
390
to
395
| // NOTE: Axelar simply provides the hexadecimal string of an EVM | ||
| // address as the `sourceAddress` argument. Solidity does on the | ||
| // other side recognize the hex-encoding and encode the hex bytes to | ||
| // utf-8 bytes. | ||
| // | ||
| // Hence, we are reverting this process here. |
There was a problem hiding this comment.
Nit: Formatting off.
Suggested change
| // NOTE: Axelar simply provides the hexadecimal string of an EVM | |
| // address as the `sourceAddress` argument. Solidity does on the | |
| // other side recognize the hex-encoding and encode the hex bytes to | |
| // utf-8 bytes. | |
| // | |
| // Hence, we are reverting this process here. | |
| // NOTE: Axelar simply provides the hexadecimal string of an EVM | |
| // address as the `sourceAddress` argument. Solidity does on the | |
| // other side recognize the hex-encoding and encode the hex bytes to | |
| // utf-8 bytes. | |
| // | |
| // Hence, we are reverting this process here. |
wischli
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The address that we are receiving from EVM chains is a
utf-8(hex(address))encoded byte bloob. This was an issue before because we expected it to be just an[u8; 20].Changes and Descriptions
Checklist: