Investments: benchmarks #1563
Merged
Investments: benchmarks #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
I7-optimisation
lemunozm
force-pushed
the
investments/benchmarks
branch
from
6bee592
to
d6eafbd
Compare
lemunozm
force-pushed
the
investments/benchmarks
branch
from
b80e42c
to
21d4d60
Compare
lemunozm
commented
Sep 25, 2023
| } | ||
|
|
||
| #[benchmark] | ||
| fn collect_redemptions(n: Linear<1, 10>) { |
There was a problem hiding this comment.
Suggested change
| fn collect_redemptions(n: Linear<1, 10>) { | |
| fn collect_redemptions(n: Linear<1, { T::MaxOutstandingCollects::get() }>) { |
Tech debt once we upgrade to Polkadot v0.9.39
mustermeiszer
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #918
Changes and Descriptions
MockRuntimealtairandcentrifugeruntimes.investment_idfrom a pool. I think this from feat: orderbook bench helper #1558 could solve the issue.Benchmarking results (already normalized to our node times)
update_invest_order()&update_invest_redeem():94_000_000 + reads(8) + writes(4)collect_investments()&collect_investments_for()&collect_redemptions()&collect_redemptions_for():97_000_000 + 4_000_000 * N + reads(7) + reads(1) * N + writes(3)