Release v0.10.34 #1573

wischli · 2023-09-27T16:53:48Z

Description

LPs

The following changes affect all runtimes:

Removes StumpInboundQueue and sets LiquidityPools as InboundQueue implementer
Removes filter on OutboundQueue
Removes UpdateTrancheInvestmentLimit message
Moves configuration of LP related pallets to new liquidity_pools module

USDC

The following changes only affect centrifuge runtime:

Adds three more LP wrapped USDC variants
Enables bidirectional OrderBook trading pairs for all four LP wrapped USDC variants to/from DOT native USDC

Runtime upgrade

Bumps spec and toml versions
Updates weights

Misc

Enables benchmarks for some missing pallets
- Altair: Elections, PolkadotXcm, CumulusXcmpQueue, LiquidityRewards
- Centrifuge: PolkadotXcm, LiquidityRewards
Fixes minor issue with pallet-loans benchmark for apply_transfer_debt which did not factor in a paremeter as defined in the corresponding WeightInfo

Checklist:

I have added Rust doc comments to structs, enums, traits and functions
I have made corresponding changes to the documentation
I have performed a self-review of my code
I have added tests that prove my fix is effective or that my feature works

wischli · 2023-09-28T04:56:56Z

/benchmark centrifuge

github-actions · 2023-09-28T04:58:45Z

✅ Uploaded benchmarks for: centrifuge ✅
Find the artifact here: https://github.com/centrifuge/centrifuge-chain/actions/runs/6334700805

wischli · 2023-09-28T10:01:09Z

/benchmark centrifuge

github-actions · 2023-09-28T10:02:09Z

✅ Uploaded benchmarks for: centrifuge ✅
Find the artifact here: https://github.com/centrifuge/centrifuge-chain/actions/runs/6337391897

wischli · 2023-09-28T10:02:57Z

FYI: Need to benchmark again, because the benchmarks were missing #1465 which introduced a breaking weights change. Moreover, the Centrifuge runtime did not have pallet_xcm benchmarks enabled, such that these were not generated.

wischli · 2023-09-28T10:03:35Z

.github/CODEOWNERS

@@ -38,7 +39,7 @@ libs/traits/src/changes.rs @lemunozm
 libs/traits/src/data.rs @lemunozm

 ## Changes to runtime
-runtime/common/* @mustermeiszer @NunoAlexandre @hieronx @lemunozm
+runtime/common/* @mustermeiszer @NunoAlexandre @hieronx @lemunozm @wischli


I hope it's fine I have added myself here.

wischli · 2023-09-28T14:30:43Z

pallets/loans/src/benchmarking.rs

+		let n in 2..Helper::<T>::max_active_loans() - 2;
+
 		let any = account("any", 0, 0);
-		let pool_id = Helper::<T>::prepare_benchmark();
+		let pool_id = Helper::<T>::initialize_active_state(n);


@lemunozm I noticed that the loans benchmarks did parametrize apply_transfer_debt which created compiler issues as the pallet_loans::weights::WeightInfo expect the existence of a parameter. AFAICT, this provided solution should be appropriate. WDYT?

My fault! You did the perfect fix for this! 💯

Thanks, and sorry for missing this

lemunozm

LGTM, thanks for all the work on this @wischli !! 🚀

lemunozm · 2023-09-28T14:55:46Z

runtime/altair/src/liquidity_pools.rs

+	type TrancheId = TrancheId;
+	type TrancheTokenPrice = PoolSystem;
+	type TreasuryAccount = TreasuryAccount;
+	type WeightInfo = ();


I have fear when I see the () type as it seems as if it's using Zero weights. Maybe as a way of confirming the reading the weights have actually a value, we could name the type as DefensiveWeights, and use it here.

lemunozm · 2023-09-28T14:56:21Z

runtime/altair/src/liquidity_pools.rs

+	type TokenSwapOrderId = u64;
+	type TokenSwaps = OrderBook;
+	type TrancheId = TrancheId;
+	type WeightInfo = ();


Should WeightInfo be removed if there are no extrinsics associated with this pallet?

libs/types/src/tokens.rs

lemunozm

LGTM!

wischli · 2023-09-29T09:01:23Z

runtime/centrifuge/src/migrations.rs

+			pallet_pool_system::Pool::<Runtime>::mutate(ANEMOY_POOL_ID, |maybe_details| {
+				if let Some(details) = maybe_details {
+					details.currency = CURRENCY_ID_DOT_NATIVE;
+					log::info!("anemoy_pool::Migration: currency set to USDC ✓");
+				} else {
+					log::warn!("anemoy_pool::Migration: Pool details empty, skipping migration");
+				}


Comment: This would have bricked Catalyst due to unwrapping a None variant. We need to be more attentive of never unwrapping outside of tests.

Thanks for the catch, @wischli. This is my bad but also reveals the necessity for a more formal review process and review requirements. In this case, requiring a migration on Centrifuge to be tested against Centrifuge AND Catalyst before being approved, whereas we only tested against Centrifuge.

mustermeiszer

LGTM!

mustermeiszer · 2023-09-29T09:51:46Z

runtime/development/src/liquidity_pools.rs


 parameter_types! {
 	pub const MaxIncomingMessageSize: u32 = 1024;
 	pub Sender: AccountId = GatewayAccountProvider::<Runtime, LocationToAccountId>::get_gateway_account();
 }

 impl pallet_liquidity_pools_gateway::Config for Runtime {
-	type AdminOrigin = EnsureRoot<AccountId>;
-	type InboundQueue = crate::LiquidityPools;
+	type AdminOrigin = EnsureRootOr<HalfOfCouncil>;


Why half of council in dev? No blocker, just curious.

Copy paste error. I had this file removed at some point. Would it be fine to fix this in a post-release PR?

Of course. Root is still enabled so no problem.

mustermeiszer · 2023-09-29T09:54:02Z

runtime/centrifuge/src/liquidity_pools.rs

+}
+
+impl pallet_liquidity_pools::Config for Runtime {
+	// NOTE: No need to adapt that. The Router is an artifact and will be removed


Artifact indeed, sorry about that. Can I remove this in a post-release PR? CI takes ages as each push builds new images.

Next release I need to apply another branching strategy, i.e. have an rc branch which wants to merge into release-vx.y.z which is based on main after feature freeze. This way, we don't need to rebase the rc branch on any non release related push to main. However, merging the release branch into main still creates CI overhead but I suppose that's fine.

wischli added 8 commits September 27, 2023 16:09

feat: add usdc migration

4490d8f

chore: bump dev spec_version

477b342

chore: bump centrifuge spec_version

0bc39bb

fix: foreign investments bench

d41f4f3

chore: bump root toml version

47569ef

feat: add LP Celo wrapped USDC

e277015

fmt: fix

ca9070f

Merge remote-tracking branch 'origin/main' into release-v0.10.34

d448891

wischli self-assigned this Sep 28, 2023

wischli added the I9-release A specific release. label Sep 28, 2023

wischli added 10 commits September 28, 2023 07:11

feat: rm StumpInboundQueue

4649fb3

refactor: move LP config to separate file

0f187e3

fix: remove UpdateTrancheInvestmentLimit msg

c2c5bb5

Merge remote-tracking branch 'origin/main' into release-v0.10.34

049007b

chore: add foreign investments to CODEOWNERS

d64b21f

chore: update centrifuge benchmarks

68ceafd

chore: update defensive manual LP benchmarks

a0a7edc

chore: update altair weights

ed46f62

fix: add missing benches to altair runtime

1cd69de

fix: add missing PolkadotXcm bench to cfg runtime

00d4466

wischli commented Sep 28, 2023

View reviewed changes

wischli added 3 commits September 28, 2023 15:58

chore: update weights again

2007529

fix: enable LiquidityRewards benches in runtimes

b9899e0

fix: missing param loans bench apply_transfer_debt

e2fa794

wischli marked this pull request as ready for review September 28, 2023 14:29

wischli requested review from mustermeiszer, NunoAlexandre, hieronx and lemunozm as code owners September 28, 2023 14:29

wischli commented Sep 28, 2023

View reviewed changes

lemunozm reviewed Sep 28, 2023

View reviewed changes

wischli added 2 commits September 29, 2023 10:49

fix: upgrade script

1698109

fix: anemoy migration catalyst + remove USDC suffix

0a9ef1c

lemunozm approved these changes Sep 29, 2023

View reviewed changes

wischli commented Sep 29, 2023

View reviewed changes

mustermeiszer approved these changes Sep 29, 2023

View reviewed changes

wischli merged commit e53b5e8 into main Oct 4, 2023
26 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v0.10.34 #1573

Release v0.10.34 #1573

wischli commented Sep 27, 2023 •

edited

wischli commented Sep 28, 2023

github-actions bot commented Sep 28, 2023 •

edited

wischli commented Sep 28, 2023

github-actions bot commented Sep 28, 2023 •

edited

wischli commented Sep 28, 2023

wischli Sep 28, 2023

wischli Sep 28, 2023

lemunozm Sep 28, 2023

lemunozm left a comment •

edited

lemunozm Sep 28, 2023

lemunozm Sep 28, 2023

lemunozm left a comment

wischli Sep 29, 2023

NunoAlexandre Sep 29, 2023

mustermeiszer left a comment

mustermeiszer Sep 29, 2023

wischli Sep 29, 2023

mustermeiszer Sep 29, 2023

mustermeiszer Sep 29, 2023

wischli Sep 29, 2023 •

edited

Release v0.10.34 #1573

Release v0.10.34 #1573

Conversation

wischli commented Sep 27, 2023 • edited

Description

LPs

USDC

Runtime upgrade

Misc

Checklist:

wischli commented Sep 28, 2023

github-actions bot commented Sep 28, 2023 • edited

wischli commented Sep 28, 2023

github-actions bot commented Sep 28, 2023 • edited

wischli commented Sep 28, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lemunozm left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lemunozm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mustermeiszer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wischli Sep 29, 2023 • edited

Choose a reason for hiding this comment

wischli commented Sep 27, 2023 •

edited

github-actions bot commented Sep 28, 2023 •

edited

github-actions bot commented Sep 28, 2023 •

edited

lemunozm left a comment •

edited

wischli Sep 29, 2023 •

edited