New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove spec_version check for Centrifuge 1023 migrations #1584
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not an expert in this topic, but changes look good!
@@ -1,6 +1,6 @@ | |||
[package] | |||
name = "centrifuge-runtime" | |||
version = "0.10.22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand this has not been changed for altair
because we are using development as demo now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The correct reason would be that we had not upgraded Algol or Altair yet. In contrast, Catalyst received two upgrades already from 1020 (current Centrifuge version) to 1022.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for extend!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @wischli!
Description
Removes
spec_version
checks for Anemoy, USDC and EVM Precompile Accountcode migrations.Apparently, we cannot rely on the result of
try-runtime
which succeeded for all these migrations. However, in practice neither Dev/Demo nor Catalyst ran the EVM Accountcode migrations (Anemoy & USDC migrations ran on Catalyst in a previous upgrade from 1020 to 1021). My understanding is that at the time of executingon_runtime_upgrade()
, the spec_version has been bumped already andLastRuntimeUpgrade
updated to the currentspec_version
. I could not find any way of reading the pre upgrade spec_version.None of the migrations performs many reads or writes. Moreover, they were adjusted such that no written storage is mutated. Thus, they cannot do harm.
Checklist: