Oracles: Protect from configuring with duplicated feeders #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
I3-annoyance
lemunozm
requested review from
NunoAlexandre,
cdamian,
wischli and
mustermeiszer
|
Thanks! Waiting to #1658 first |
lemunozm
dismissed stale reviews from mustermeiszer, NunoAlexandre, and cdamian
The base branch was changed.
lemunozm
force-pushed
the
oracle/feeders-as-set
branch
from
8266d62
to
2962131
Compare
mustermeiszer
approved these changes
Dec 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should avoid configuring the feeders with a vector to prevent the caller from adding duplicated feeders. Instead of checking duplications in runtime, we can ensure this behavior in the type system using a set.