Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try-runtime to ci pipeline #1735

Merged
merged 15 commits into from
Mar 20, 2024
Merged

Add try-runtime to ci pipeline #1735

merged 15 commits into from
Mar 20, 2024

Conversation

gpmayorga
Copy link
Contributor

Description

Add try-runtime for Altair and Centrifuge to CI

Fixes #1617

Changes and Descriptions

Add try-runtime to PRs labeled as D8-migration

@gpmayorga gpmayorga added the D8-migration Pull request touches storage and needs migration code. label Feb 16, 2024
@gpmayorga gpmayorga added D8-migration Pull request touches storage and needs migration code. and removed D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
lemunozm
lemunozm previously approved these changes Feb 16, 2024
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight to the point!

Maybe could be interesting to add the try-runtime command as an script in run-check.sh to launch in local easily for us. WDYT? No blocker anyways

.github/workflows/try-runtime.yml Outdated Show resolved Hide resolved
@gpmayorga
Copy link
Contributor Author

/try-runtime

@gpmayorga gpmayorga added D8-migration Pull request touches storage and needs migration code. and removed D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
@gpmayorga
Copy link
Contributor Author

/try-runtime

Unfortunately until this is merged to main I can't test this trigger

@gpmayorga gpmayorga added D8-migration Pull request touches storage and needs migration code. and removed D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
@gpmayorga gpmayorga added D8-migration Pull request touches storage and needs migration code. and removed D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
@gpmayorga gpmayorga added D8-migration Pull request touches storage and needs migration code. I12-ci Issue related to CI github_actions Pull requests that update GitHub Actions code and removed D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
@gpmayorga gpmayorga added crcl-cross-chain Circle cross-chain related. and removed crcl-cross-chain Circle cross-chain related. labels Feb 16, 2024
@gpmayorga gpmayorga mentioned this pull request Feb 16, 2024
12 tasks
@gpmayorga gpmayorga added D0-ready Pull request can be merged without special precaution and notification. and removed D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
@gpmayorga
Copy link
Contributor Author

gpmayorga commented Feb 16, 2024

Here's the job with the latest code:
https://github.com/centrifuge/centrifuge-chain/actions/runs/7932658994/job/21659621848

It seems to be running fine (it fails where it should). Feel free to add the D8-migration tag if you want to see the job running. See it running at https://github.com/centrifuge/centrifuge-chain/actions/workflows/try-runtime.yml after adding the tag

@gpmayorga gpmayorga enabled auto-merge (squash) February 16, 2024 17:26
@gpmayorga gpmayorga added crcl-cross-chain Circle cross-chain related. D8-migration Pull request touches storage and needs migration code. and removed crcl-cross-chain Circle cross-chain related. D8-migration Pull request touches storage and needs migration code. labels Feb 16, 2024
@lemunozm
Copy link
Contributor

I would say, wait until #1641 is fixed to not break all PR that contains migrations. It should be fixed before the next RU, so maybe 1-2 weeks until merging this PR. Is it ok?

@wischli
Copy link
Contributor

wischli commented Feb 16, 2024

I would say, wait until #1641 is fixed to not break all PR that contains migrations. It should be fixed before the next RU, so maybe 1-2 weeks until merging this PR. Is it ok?

Unfortunately, we need to merge #1641 and upgrade all chains including the fix before we can expect try-runtime to work. I want to include these fixes into RU 1025 such that 2 weeks seems reasonable.

@gpmayorga gpmayorga added D8-migration Pull request touches storage and needs migration code. and removed D8-migration Pull request touches storage and needs migration code. labels Mar 18, 2024
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another CI improvement!

@gpmayorga gpmayorga merged commit 47fff26 into main Mar 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D0-ready Pull request can be merged without special precaution and notification. github_actions Pull requests that update GitHub Actions code I12-ci Issue related to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHA pipeline features
3 participants