Fix: order book working with local currencies #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemunozm
added
I2-bug
lemunozm
commented
Mar 18, 2024
pallets/order-book/src/lib.rs
Outdated
Comment on lines
671
to
684
| let from_decimals = T::AssetRegistry::metadata(&T::NativeCurrency::get()) | ||
| .ok_or(Error::<T>::InvalidCurrencyId)? | ||
| .decimals; | ||
|
|
||
| let to_decimals = T::AssetRegistry::metadata(¤cy) | ||
| .ok_or(Error::<T>::InvalidCurrencyId)? | ||
| .decimals; | ||
|
|
||
| Ok(convert_balance_decimals( | ||
| from_decimals, | ||
| to_decimals, | ||
| T::MinFulfillmentAmountNative::get().into(), | ||
| )? | ||
| .into()) |
There was a problem hiding this comment.
We can avoid having an external trait to do this if we know the Native currency
lemunozm
force-pushed
the
fix/decimal-convert-local
branch
from
5bf28de
to
99e0bcf
Compare
wischli
reviewed
Mar 18, 2024
|
😆, thanks for reviewing William! |
|
Not so fast, benchmarking is failing |
|
Modified the fix a bit to use the native decimals instead of the native currency itself, to avoid difficult initializations of the native currency in benchmarking of pallets that uses order-book |
wischli
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DecimalConvertertrait, which does not handle Local currencies.order-bookgenerically for any currency.