Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permit token mux calls for ProxyType::Borrow #1774

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: permit token mux calls for ProxyType::Borrow #1774

merged 1 commit into from
Mar 18, 2024

Conversation

wischli
Copy link
Contributor

@wischli wischli commented Mar 18, 2024

Description

Adds TokenMux call permissions to ProxyType::Borrow

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@wischli wischli added I3-annoyance The code behaves as expected, but "expected" is an issue. P7-asap Issue should be addressed in the next days. labels Mar 18, 2024
@wischli wischli self-assigned this Mar 18, 2024
lemunozm
lemunozm approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@wischli wischli merged commit 6f0dd0a into main Mar 18, 2024
9 checks passed
@wischli wischli deleted the fix/borrow-proxy-token-mux branch March 18, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemunozm lemunozm lemunozm approved these changes

@mustermeiszer mustermeiszer mustermeiszer approved these changes

Assignees

@wischli wischli

Labels
I3-annoyance The code behaves as expected, but "expected" is an issue. P7-asap Issue should be addressed in the next days.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wischli @lemunozm @mustermeiszer