identity migration: update to latest contracts #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikiquantum
approved these changes
Feb 14, 2019
| @@ -29,6 +30,9 @@ func (Bootstrapper) Bootstrap(ctx map[string]interface{}) error { | |||
| } | |||
| client := ctx[ethereum.BootstrappedEthereumClient].(ethereum.Client) | |||
|
|
|||
| fmt.Println("anchors") | |||
There was a problem hiding this comment.
I know this is testing material, let's try to keep as "production" as possible, bc otherwise when we merge to develop it will be harder to catch.
| @@ -20,6 +20,7 @@ for d in $(go list -tags=integration ./... | grep -v vendor); do | |||
| cat profile.out >> coverage.txt | |||
| rm profile.out | |||
| fi | |||
| exit $status | |||
| func runNewSmartContractMigrations() { | ||
|
|
||
| // TODO: store identity bytecode in config and remove func | ||
| func getIdentityByteCode() string { |
There was a problem hiding this comment.
Where are we using this?
There was a problem hiding this comment.
We are using it for CreateIdentity to check if it was successful
mikiquantum
added a commit
that referenced
this pull request
Feb 25, 2019
* identity migration: update to latest contracts (#748) * use new identity contracts * removed registry from config * removed helper functions * identity migrate cmd package * formatting * identity migration: new package structure (#749) * use new identity contracts * removed registry from config * removed helper functions * identity migrate cmd package * formatting * fixed changes * package changed * moved did service interface * fixed tests in ideth package * added did.go * fixed cmd package (#750) * identity migration: mockService and boostrapper document service (#751) * fixed cmd package * added mock did service and did service to documents bootstrapper * fixed document bootstrapper * removed old service from document bootstrapper * identity migration: documents (#757) * fixed cmd package * added mock did service and did service to documents bootstrapper * fixed document bootstrapper * removed old service from document bootstrapper * migration identity replaced validators * fixed selfSignatureValidator test * fixed signature Validator * documents unit test fixed * fixed tests for invoice and purchaseorder * formatting * Identity (#758) * Refactor/nfts remove cd (#747) * config * p2p * Correct logs for transaction tasks (#753) * wip * fix p2p and config tests * fix documents/invoice * fix po tests * comments * fix cmd * Fix unit tests except oldID + anchor and linting (#761) * Refactor/nfts remove cd (#747) * config * p2p * Correct logs for transaction tasks (#753) * wip * fix p2p and config tests * fix documents/invoice * fix po tests * comments * fix cmd * fmt + fix all unit tests except anchor+oldID * fix unit tests * swagger * Id migration: new anchoring (#763) * removed old anchor contract * fixed unit tests * updated anchor methods * fixed integration test anchor commit * removed event listener task from anchor * anchor passing uuid * fixed anchoring integration test * added channel as return * added integration test for anchoring * fixed identity tests * fixed unit tests * formatting * WIP: Fix integration tests (#764) * Refactor/nfts remove cd (#747) * config * p2p * Correct logs for transaction tasks (#753) * wip * fix p2p and config tests * fix documents/invoice * fix po tests * comments * fix cmd * fmt + fix all unit tests except anchor+oldID * fix unit tests * swagger * compilation error fix integration * keys * test * integration * fix integration tests * fix unit tests * Merged develop (#767) * Refactor/nfts remove cd (#747) * config * p2p * Correct logs for transaction tasks (#753) * wip * fix p2p and config tests * Converting TX API to use Hex strings (#754) * Converting TX API to use Hex strings * test * comment * fix tests * fix documents/invoice * fix po tests * comments * fix cmd * fmt + fix all unit tests except anchor+oldID * hash instead of copying the message (#759) Hash the message before signing * Report card * fix unit tests * NFT uniqeness proofs (#736) Add NFT proofs - Uniqueness proof - NFT read access proof More here - https://hackmd.io/ps0X0jRkRHaACP6aPtGzag * swagger * compilation error fix integration * keys * test * integration * fix integration tests * Update protobufs (#765) * Update protobufs * test * fix unit tests * revert migrations * fixed multi case identity address * nft in testworld uncomment * fixed unit tests in configstore * ID Comment Fixes (#772) * Refactor/nfts remove cd (#747) * config * p2p * Correct logs for transaction tasks (#753) * wip * fix p2p and config tests * Converting TX API to use Hex strings (#754) * Converting TX API to use Hex strings * test * comment * fix tests * fix documents/invoice * fix po tests * comments * fix cmd * fmt + fix all unit tests except anchor+oldID * hash instead of copying the message (#759) Hash the message before signing * Report card * fix unit tests * NFT uniqeness proofs (#736) Add NFT proofs - Uniqueness proof - NFT read access proof More here - https://hackmd.io/ps0X0jRkRHaACP6aPtGzag * swagger * compilation error fix integration * keys * test * integration * fix integration tests * Update protobufs (#765) * Update protobufs * test * fix unit tests * revert migrations * fix comments * fix comments * Add bytecode check (#774) * Refactor/nfts remove cd (#747) * config * p2p * Correct logs for transaction tasks (#753) * wip * fix p2p and config tests * Converting TX API to use Hex strings (#754) * Converting TX API to use Hex strings * test * comment * fix tests * fix documents/invoice * fix po tests * comments * fix cmd * fmt + fix all unit tests except anchor+oldID * hash instead of copying the message (#759) Hash the message before signing * Report card * fix unit tests * NFT uniqeness proofs (#736) Add NFT proofs - Uniqueness proof - NFT read access proof More here - https://hackmd.io/ps0X0jRkRHaACP6aPtGzag * swagger * compilation error fix integration * keys * test * integration * fix integration tests * Update protobufs (#765) * Update protobufs * test * fix unit tests * revert migrations * add bytecode check * add bytecode check * fixes * fixed testworld bytecode check * formatting * remove bytecode check * remove bin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrated packages