-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Axelar router #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just one comment but I'm happy if we address it in a separate PR
// Script to deploy Connectors with an Axelar router. | ||
contract ConnectorAxelarScript is Script { | ||
// address(0)[0:20] + heccak("Centrifuge")[21:32] | ||
bytes32 SALT = 0x000000000000000000000000000000000000000075eb27011b69f002dc094d05; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why we have a constant SALT
? And what why the encoded meaning behind it is significant here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah there's no documentation on this right now: foundry-rs/book#782
The salt
itself leads to deploying contracts to the same address on different chains.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
First setup of the axelar router. This is assuming the axelar gateway address (this is using an upgradeable proxy, so that seems like a safe assumption) and the centrifuge chain ID are stable, and if we want to swap the gateway (currently referenced as the
connector
, but this will change in #52) we would deploy a new router as well.