identity: createConfig #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xmxanuel
commented
Feb 11, 2019
xmxanuel
commented
- create config with new identity
Codecov Report
@@ Coverage Diff @@
## develop #741 +/- ##
===========================================
+ Coverage 53.31% 53.34% +0.02%
===========================================
Files 119 119
Lines 9110 9208 +98
===========================================
+ Hits 4857 4912 +55
- Misses 3678 3717 +39
- Partials 575 579 +4
Continue to review full report at Codecov.
|
mikiquantum
reviewed
Feb 12, 2019
cmd/common.go
Outdated
| @@ -58,6 +68,110 @@ func addKeys(config config.Configuration, idService identity.Service) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func getKeyPairsFromConfig(config config.Configuration) (map[int]did.Key, error) { | |||
There was a problem hiding this comment.
I believe this function should be more in the identity package as it will be reused from the API as well?
cmd/common.go
Outdated
| return keys, nil | ||
| } | ||
|
|
||
| func addKeysFromConfig(ctx map[string]interface{}, cfg config.Configuration) error { |
cmd/common.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func createIdentity(ctx map[string]interface{}, cfg config.Configuration, configFile *viper.Viper) error { |
| @@ -80,7 +80,7 @@ func getAnchorAddress() common.Address { | |||
| // --------------------------------------------------------------------------------------------------------------------- | |||
| func migrateNewIdentityContracts() { | |||
There was a problem hiding this comment.
This logic in this file is only for testing, we should think about removing it to the test bootstapper instead.
|
ah okay. for the codecov the test needs to be in the same package |
mikiquantum
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.