Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label offset #30

Closed

Conversation

hyperpuncher
Copy link
Contributor

image
image

@ceoloide
Copy link
Owner

ceoloide commented May 7, 2024

Thank you for this PR!

Before I merge, I need to confirm what happens when footprints are rotated in KiCad

With the MCU, I noticed that justify left caused the text to switch side at certain angles, and it may be happening with this footprint as well.

Will report back ASAP.

@hyperpuncher
Copy link
Contributor Author

Yep, you're right, it is happening with this footprint as well, it was already rotated 180°.

@ceoloide
Copy link
Owner

ceoloide commented May 7, 2024

Then I know how to resolve, I just need to re-align the text with justify center. It may be a KiCad issue as well, will investigate and commit the changes to all the footprints that use justify left / right.

Thanks for raising this though!

@ceoloide ceoloide closed this May 7, 2024
@hyperpuncher hyperpuncher deleted the power_switch_labels_fix branch May 7, 2024 15:09
ceoloide added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants