cleanup virtualenv found in /tmp #71
Conversation
ghost
assigned 
|
might want to |
|
lgtm, didn't realize the check bot used this too |
Before building we need to get rid of virtualenv created in /tmp as they may not contain what we expect. Fixes: http://tracker.ceph.com/issues/15375 Signed-off-by: Loic Dachary <loic@dachary.org>
|
@tchaikov repushed thanks :-) |
|
@jdurgin I tried to go in the direction of having pip installed modules instead of python files that are moved around. The make check needs to know where the ceph-disk and ceph-detect-init modules have been built (i.e. pip install -e), which happens during make all. It is removed by make clean but ... if a build fails and aborts before make clean gets a chance to run, make all will not pip install -e and I think that's what we're having. I'm not 100% sure but that seems a plausible theory at the moment :-) |
|
This is better than before, but anything that goes in /tmp should have some kind of unique identifier so that multiple concurrent builds by different users don't fail. See: http://tracker.ceph.com/issues/15385 |
Before building we need to get rid of virtualenv created in /tmp as they
may not contain what we expect.
Signed-off-by: Loic Dachary loic@dachary.org