Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ceph-windows-image-build] Prep Windows image for Openstack and integration testing #1983

Closed
wants to merge 1 commit into from

Conversation

Dany9966
Copy link

@Dany9966 Dany9966 commented Mar 31, 2022

These pull request include:

  • Adding support for installing .msi packages using the Install-Tool function
  • Cloudbase-init installation function, so the image can boot and receive user data on Openstack
  • Flexible I/O tool installation function, used for one of the Ceph on Windows integration tests

@ceph-jenkins
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment.

Everything else LGTM.

ceph-windows-image-build/build/setup.ps1 Outdated Show resolved Hide resolved
@Dany9966 Dany9966 changed the title Prep Windows image for Openstack and integration testing [ceph-windows-image-build]Prep Windows image for Openstack and integration testing Apr 4, 2022
@ionutbalutoiu ionutbalutoiu changed the title [ceph-windows-image-build]Prep Windows image for Openstack and integration testing [ceph-windows-image-build] Prep Windows image for Openstack and integration testing Apr 5, 2022
These patches include:

  - Adding support for installing .msi packages using the Install-Tool function
  - Cloudbase-init installation function, so the image can boot and receive user
    data on Openstack
  - Flexible I/O tool installation function, used for one of the Ceph on Windows
    integration tests
Copy link
Contributor

@ionutbalutoiu ionutbalutoiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ionutbalutoiu
Copy link
Contributor

/cc: @djgalloway

I reviewed this PR and from my perspective, this is good to be merged.

@ionutbalutoiu
Copy link
Contributor

We don't need this anymore.

This PR will be integrated in the upstream Ceph QA workunit scripts when merging the basic Windows Teuthology test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants