ceph-dev: allow for a strictly centos9 build #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancich
force-pushed
the
wip-allow-distro-specific-builds
branch
from
30f3596
to
29fd6b5
Compare
ivancich
requested review from
zmc and
idryomov
and removed request for
djgalloway
idryomov
reviewed
Feb 2, 2023
For those working on details of a centos9 build, testing should not involve a bunch of other builds. Presenting this as a potential solution. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
ivancich
force-pushed
the
wip-allow-distro-specific-builds
branch
from
29fd6b5
to
ff5b2cc
Compare
|
@idryomov Once the CI checks are done, may I merge? Or is there additional testing required? (This is my first ceph-build PR and don't want to make any assumptions.) Thanks for your help! |
idryomov
approved these changes
Feb 2, 2023
I think so! |
zmc
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those working on details of a centos9 build, testing should not involve a bunch of other builds. Presenting this as a potential solution.
Signed-off-by: J. Eric Ivancich ivancich@redhat.com
I don't know if this is the best solution to limiting builds. I'm not sure that it scales well. But I thought I'd offer this PR to start a discussion and see what the best approach is.