Skip to content

Commit

Permalink
ceph: print the client global_id in all the debug logs
Browse files Browse the repository at this point in the history
Multiple cephfs mounts on a host is increasingly common so disambiguating
messages like this is necessary and will make it easier to debug
issues.

URL: https://tracker.ceph.com/issues/61590
Cc: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Signed-off-by: Xiubo Li <xiubli@redhat.com>
  • Loading branch information
lxbsz committed Jun 14, 2023
1 parent e1683d3 commit 363520b
Show file tree
Hide file tree
Showing 18 changed files with 1,891 additions and 1,342 deletions.
6 changes: 4 additions & 2 deletions fs/ceph/acl.c
Expand Up @@ -15,6 +15,7 @@
#include <linux/slab.h>

#include "super.h"
#include "mds_client.h"

static inline void ceph_set_cached_acl(struct inode *inode,
int type, struct posix_acl *acl)
Expand All @@ -31,6 +32,7 @@ static inline void ceph_set_cached_acl(struct inode *inode,

struct posix_acl *ceph_get_acl(struct inode *inode, int type, bool rcu)
{
struct ceph_client *cl = ceph_inode_to_client(inode);
int size;
unsigned int retry_cnt = 0;
const char *name;
Expand Down Expand Up @@ -72,8 +74,8 @@ struct posix_acl *ceph_get_acl(struct inode *inode, int type, bool rcu)
} else if (size == -ENODATA || size == 0) {
acl = NULL;
} else {
pr_err_ratelimited("get acl %llx.%llx failed, err=%d\n",
ceph_vinop(inode), size);
pr_err_ratelimited_client(cl, "%llx.%llx failed, err=%d\n",
ceph_vinop(inode), size);
acl = ERR_PTR(-EIO);
}

Expand Down

0 comments on commit 363520b

Please sign in to comment.