Use local epel mirrorlist #142
Conversation
|
I didn't know you could put newlines in like that? |
|
Tested it on plana11. See [repository] OPTIONS section. The other way to maintain this would be to create separate local files containing mirror URLs |
| epel_repos: | ||
| epel: | ||
| name: "Extra Packages for Enterprise Linux" | ||
| baseurl: "{{ epel_mirror_baseurl }}/{{ ansible_distribution_major_version }}/$basearch" | ||
| mirrorlist: "{{ epel_mirrorlist }}/metalink?repo=epel-{{ ansible_distribution_major_version }}&arch=$basearch" | ||
| baseurl: "{{ epel_mirror_baseurl }}/{{ ansible_distribution_major_version }}/$basearch\nhttp://mirrors.cat.pdx.edu/epel/{{ ansible_distribution_major_version }}/$basearch\nhttp://mirror.pnl.gov/epel/{{ ansible_distribution_major_version }}/$basearch\nhttp://fedora-epel.mirror.lstn.net/{{ ansible_distribution_major_version }}/$basearch" |
There was a problem hiding this comment.
Could we instead have ansible manage a file, put that file on the remote and then point to it here in baseurl?
All this put into one string is difficult to parse, IMHO.
There was a problem hiding this comment.
Agreed, a separate file sounds a lot saner
There was a problem hiding this comment.
A template might be useful here:
http://docs.ansible.com/ansible/template_module.html
djgalloway
force-pushed
the
wip-12739
branch
from
fdec37c
to
627e915
Compare
|
Suggestions on a cleaner way to do this are welcome |
| @@ -16,6 +16,12 @@ | |||
| register: epel_repo | |||
| with_dict: epel_repos | |||
|
|
|||
| - name: Configure local epel mirrorlists | |||
| template: src={{ item }} dest=/etc/yum.repos.d/{{ item }} owner=root group=root mode=0644 | |||
There was a problem hiding this comment.
nitpick: I prefer this kind of formatting:
template:
src: "{{ item }}"
dest: "/etc/yum.repos.d/{{ item }}"
...
I think it's easier to read and makes for better diffs if/when we ever change this code.
|
All I had was a style nitpick, everything else here looks good to me. |
djgalloway
force-pushed
the
wip-12739
branch
from
627e915
to
be59304
Compare
Signed-off-by: dgalloway <dgallowa@REDHAT.COM>
djgalloway
force-pushed
the
wip-12739
branch
from
be59304
to
537e924
Compare
|
thanks @djgalloway ! |
Related to:
http://tracker.ceph.com/issues/12739
http://tracker.ceph.com/issues/12778