-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync cluster bootstrap using etcd #28
Conversation
@BugRoger Thanks a lot for pushing this. Actually that's part of the vision I have for ceph-docker. @Ulexus I understand your concern about the usage of etcd and it's fair. However I believe it has a sort of consensus now. Many big projects like Kubernetes are using it (Red Hat Atomic too). I'd be really happy to see this in ceph-docker. I'll review that patch soon. |
exit 0 | ||
fi | ||
|
||
# Aquire lock to not run into race conditions with parallel bootstraps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/Aquire/Acquire/
@BugRoger Just reviewed that, the overall looks really good, I just left a couple of questions. |
MAINTAINER Sébastien Han "seb@redhat.com" | ||
|
||
RUN wget https://github.com/coreos/etcd/releases/download/v0.4.6/etcd-v0.4.6-linux-amd64.tar.gz | ||
RUN tar xzvf etcd-v0.4.6-linux-amd64.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ulexus what do you think of adding etcdctl to ceph/base?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely
I'm pretty sure etcdctl 2 is compatible with etcd 0.4, so we should probably use it instead. CoreOS is still shipping with 0.4.7, though, so we should probably verify that (I'll do so when I get in to the office in a couple hours) @leseb I think including etcdctl in base is a great idea. That would allow me to rewrite osd, Mon, etc, to (optionally) use etcd, as well. This feature was requested on my old repo, anyway. |
Verified that etcdctl v2.0.4 works just fine with etcd v0.4.6 (current CoreOS beta, 584, and stable, 557.2). I don't have an alpha box running v0.4.7, but I can't imagine it not working with v0.4.7 if it works with v0.4.6. v0.4.7 is just a staging update for migration to 2.x. |
@Ulexus Thanks for the quick tests :) |
I don't see a reason not to commit this PR then update base with etcdctl v2.0.4, then update this component. Objections? |
Well, except for the misspelling you found, anyway. :) |
No objections unless @BugRoger wants to take care of that. |
Sync cluster bootstrap using etcd
PR #29 updated etcdctl and moves it to ceph/base |
A little late to the discussion. We'd started work on something similar using Consul for the KV. Any sense in using confd to make things a little more universal? |
Thanks for considering this. And as I see you already fixed the initial comments. You folks are quick. 😄 |
@BugRoger Thanks for this; I just used it to rebuild my broken cluster. We should definitely integrate the other components to use it effectively. |
Change kubernetes labels & osd journal size to 2GB
This container allows to automatically bootstrap a cluster or distribute existing ceph config to new hosts. It makes use of etcd to store the inital configuration. It is especially cool when run on CoreOS and bootstrapping a cluster from nothing without manual intervention. It is compatible to the existing configuration mechanisms in the
ceph-mon
containers.If this fits in the vision of
ceph-docker
I would be happy to keep on helping to maintain this config mechanism.I'm using this on my own ceph cluster as can be seen here: https://github.com/BugRoger/d26a/tree/master/units/ceph