Moved constant QUORUM_STATES into function. #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems legit :) can you squash & ping? |
This variable being a global makes chefspec lose it's mind. Updated to remove constant in favor of local variable in function
|
ping @guilhem |
|
@hufman what do you think about it? I don't want this to break one of the other PR waiting. |
|
It looks fine, I don't think this would conflict with any of the other PRs. 👍 |
guilhem
added a commit
that referenced
this pull request
Jan 13, 2015
Moved constant QUORUM_STATES into function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable being a global makes chefspec lose it's mind.
Moved it into the only function it was used in.