Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage RBD image mirroring via StorageClass parameter #676

Closed
dillaman opened this issue Oct 9, 2019 · 12 comments
Closed

Manage RBD image mirroring via StorageClass parameter #676

dillaman opened this issue Oct 9, 2019 · 12 comments
Labels
component/rbd Issues related to RBD keepalive This label can be used to disable stale bot activiity in the repo Priority-0 highest priority issue

Comments

@dillaman
Copy link

dillaman commented Oct 9, 2019

Describe the feature you'd like to have

Add a new SC 'mirroring' parameter that can be used to annotate that PVs should be mirrored via RBD mirroring. The current values for this parameter can be "off" and "journal" (or similar). When set to "journal", upon PVC creation the exclusive-lock and journaling RBD image features should be enabled. Additionally, the CSI will need to enable mirroring on the newly created RBD image via rbd mirror image enable <image-spec>. This will also imply that NBD will need to be used instead of krbd.

What is the value to the end user? (why is it a priority?)

How would the end user gain value from having this feature?

How will we know we have a good solution? (acceptance criteria)

Add a list of criteria that should be met for this feature to be useful

Additional context

Add any other context or screenshots about the feature request here.

@dillaman dillaman added Priority-0 highest priority issue release-2.0.0 v2.0.0 release labels Oct 9, 2019
@woohhan
Copy link

woohhan commented Oct 14, 2019

Hi. is this issue still on-going? or developing by someone?
If not, I would like to work on it. @dillaman @humblec @Madhu-1

and I suggest that we could divide this issue to two issues.

  1. add rbd image feature: journaling
  2. add rbd mirror image enable

@humblec
Copy link
Collaborator

humblec commented Nov 25, 2019

@WoohyungHan can you please revisit the PR or patch which solve this issue? we would like to get this in 2.0.0.

@woohhan
Copy link

woohhan commented Nov 25, 2019

@WoohyungHan can you please revisit the PR or patch which solve this issue? we would like to get this in 2.0.0.

sure, I will. @humblec

@Madhu-1 Madhu-1 added Release-2.1.0 and removed release-2.0.0 v2.0.0 release labels Jan 20, 2020
@nixpanic nixpanic added this to TODO in Release v2.1 Jan 30, 2020
@dillaman
Copy link
Author

This requires k8s CSI external-provisioner PR kubernetes-csi/external-provisioner#399

@dillaman
Copy link
Author

We want to support the new Ceph Octopus snapshot-based mirroring, so the storage class's "mirroring" attribute should really be an enum of "disabled" (default), "journal", or "snapshot". The snapshot-based mirroring should be functional with the existing krbd driver. The journal-based mirroring mode requires rbd-nbd, but that is not yet production ready since we have no upgrade path for it.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 20, 2020

Moved this out of release-v3.0.0 milestone

@stale
Copy link

stale bot commented Oct 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 22, 2020
@stale
Copy link

stale bot commented Nov 9, 2020

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@stale stale bot closed this as completed Nov 9, 2020
Backup & Restore automation moved this from To do to Done Nov 9, 2020
@Madhu-1 Madhu-1 added the keepalive This label can be used to disable stale bot activiity in the repo label Nov 9, 2020
@Madhu-1 Madhu-1 reopened this Nov 9, 2020
Backup & Restore automation moved this from Done to In progress Nov 9, 2020
@stale stale bot removed the wontfix This will not be worked on label Nov 9, 2020
@humblec
Copy link
Collaborator

humblec commented Apr 21, 2021

Considering we have mirroring support available with release v3.3.0. I am closing this one .Please feel free to reopen if required.

@humblec humblec closed this as completed Apr 21, 2021
Backup & Restore automation moved this from In progress to Done Apr 21, 2021
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 21, 2021

We may still need this one If someone wants to enable mirroring when creating the PVC. But they need new volume replication after some time to perform failover and failback. Let's keep it open for some time.

@Madhu-1 Madhu-1 reopened this Apr 21, 2021
Backup & Restore automation moved this from Done to In progress Apr 21, 2021
@Rakshith-R
Copy link
Contributor

We may still need this one If someone wants to enable mirroring when creating the PVC. But they need new volume replication after some time to perform failover and failback. Let's keep it open for some time.

@Madhu-1 Lets close this since we have feature rich volume replication setup with csi-addons and there does not seem to be anyone who still need this feature ?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Aug 9, 2023

Yes as we have defined way for mirroring using Volume replication, closing this one.

@Madhu-1 Madhu-1 closed this as completed Aug 9, 2023
Backup & Restore automation moved this from In progress to Done Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rbd Issues related to RBD keepalive This label can be used to disable stale bot activiity in the repo Priority-0 highest priority issue
Projects
Development

Successfully merging a pull request may close this issue.

6 participants