Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store additional metadata about RBD Image owner(PVC name) in RBD Image #72

Closed
krmayankk opened this issue Aug 29, 2018 · 6 comments
Closed
Labels
good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on

Comments

@krmayankk
Copy link

implement the following proposal for csi-rbd and in core kubernetes for rbd provisioner

https://github.com/kubernetes/community/pull/1790/files

I wrote this proposal and was interested in working on this , but since we are no longer using RBD, i do not have time to work on this. Putting this here so that someone can take it from here.

@humblec humblec added the good first issue Good for newcomers label Jul 16, 2019
@humblec
Copy link
Collaborator

humblec commented Jul 16, 2019

@krmayankk would you like to send a PR on this ?

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Mar 12, 2020

PVC name can be passed to CSI driver from external-provisioner kubernetes-csi/external-provisioner#399, this can be easily done I believe, we need to decide to add it to metadata or store the pvcname-backend image mapping in omap.

@Madhu-1 Madhu-1 added the help wanted Extra attention is needed label Mar 12, 2020
@chenxu1990
Copy link
Contributor

I think it is fine to store it in metadata. What is the pros by storing in omap ? @Madhu-1

@ShyamsundarR
Copy link
Contributor

I think it is fine to store it in metadata. What is the pros by storing in omap ? @Madhu-1

We also have the use case of RBD-Mirroring and would need a similar manner to do this for CephFS subvolumes.

Currently we are thinking along the lines of naming the image with the required pvcname-namespace-<uuid> or similar constructs. Leveraging image metadata, would mean leveraging xattrs for subvolumes in the CephFS space (or similar).

The desire would be to create a common manner of accessing the metadata, and a conclusion on the approach is not yet made. We may need more time to decide on this as we work through some of the other issues and features.

@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 4, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically closed due to inactivity. Please re-open if this still requires investigation.

@stale stale bot closed this as completed Oct 12, 2020
Rakshith-R referenced this issue in Rakshith-R/ceph-csi May 26, 2022
Sync devel branch with uptream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants