rbd: use different variable instead of builtin cap attribute

[humblec]

`cap` builtin function returns the capacity of a type. Its not
good practice to use this builtin function for other variable
names, removing it here

Ref# https://golang.org/pkg/builtin/#cap

Signed-off-by: Humble Chirammal hchiramm@redhat.com

[nixpanic]

Please explain in the commit message why this is needed. Is it because a new Golang version that adds cap as builtin? I do not get any warning/error messages, and CI just works too.

Consider an empty commit message as not acceptable in 99% of all cases.

[humblec]

Please explain in the commit message why this is needed. Is it because a new Golang version that adds cap as builtin? I do not get any warning/error messages, and CI just works too.

Consider an empty commit message as not acceptable in 99% of all cases.

@nixpanic updated the commit message with the details. Please review.

please review

[pkalever]

@humblec we got few other places

internal/util/validate.go:85:   for _, cap := range req.GetVolumeCapabilities() {
internal/util/validate.go:86:           if m := cap.GetAccessMode().Mode; m == csi.VolumeCapability_AccessMode_MULTI_NODE_READER_ONLY || m == csi.VolumeCapability_AccessMode_SINGLE_NODE_READER_ONLY {

please take care of them too.

[humblec]

@humblec we got few other places

internal/util/validate.go:85:   for _, cap := range req.GetVolumeCapabilities() {
internal/util/validate.go:86:           if m := cap.GetAccessMode().Mode; m == csi.VolumeCapability_AccessMode_MULTI_NODE_READER_ONLY || m == csi.VolumeCapability_AccessMode_SINGLE_NODE_READER_ONLY {

please take care of them too.

Sure... Thanks 👍

[humblec]

@pkalever done.. May be this time the Grep foo worked for me .. I dont see any more such instances, however please confirm from your end too!

[nixpanic]

There is still a member called cap in internal/csi-common/driver.go for type CSIDriver. This needs changing too.

please review

[humblec]

There is still a member called cap in internal/csi-common/driver.go for type CSIDriver. This needs changing too.

Sure.. Done there too @nixpanic