Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: check only the stderror message for umount #1690

Merged
merged 1 commit into from Nov 18, 2020
Merged

cephfs: check only the stderror message for umount #1690

merged 1 commit into from Nov 18, 2020

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Nov 17, 2020

if the cephfs mountpoint is not mounted the umount call will fail with both stderr and err,

an error (exit status 32) and stdError (umount: /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-e622cd2b-0b87-4f49-a709-b89664ca6ec4/globalmount: not mounted.

checking stderr is sufficient to find out the mountpoint is not mounted.

Signed-off-by: Madhu Rajanna madhupr007@gmail.com

@Madhu-1
cephfs: check only the stderror message for umount
5f23c9c 
if the cephfs mountpoint is not mounted the umount
call will fail with both stderr and err,
an error (exit status 32) and stdError (umount: /var/lib/kubelet/plugins/kubernetes.io/csi/pv/pvc-e622cd2b-0b87-4f49-a709-b89664ca6ec4/globalmount: not mounted.

checking stderr is sufficient to find out the mountpoint
is not mounted.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@Madhu-1 Madhu-1 added the component/cephfs Issues related to CephFS label Nov 17, 2020
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 17, 2020

volume pvc-117bfc58-5411-4639-9b0b-38351fcf603b
Nov 17 14:07:00.766: INFO: At 2020-11-17 13:57:08 +0000 GMT - event for csi-cephfs-demo-pod: {kubelet minikube} Failed: Error: ErrImagePull
Nov 17 14:07:00.766: INFO: At 2020-11-17 13:57:08 +0000 GMT - event for csi-cephfs-demo-pod: {kubelet minikube} Failed: Failed to pull image "nginx": rpc error: code = Unknown desc = Error response from daemon: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit
Nov 17 14:07:00.766: INFO: At 2020-11-17 13:57:08 +0000 GMT - event for csi-cephfs-demo-pod: {kubelet minikube} Pulling: Pulling image "nginx"
Nov 17 14:07:00.766: INFO: At 2020-11-17 13:57:09 +0000 GMT - event for csi-cephfs-demo-pod: {kubelet minikube} Failed: Error: ImagePullBackOff
Nov 17 14:07:00.766: INFO: At 2020-11-17 13:57:09 +0000 GMT - event for csi-cephfs-demo-pod: {kubelet minikube} BackOff: Back-off pulling image "nginx"

Hitting rate limit for nginx pod also :(

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 17, 2020

/test ci/centos/mini-e2e

1 similar comment
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 17, 2020

/test ci/centos/mini-e2e

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 18, 2020

/test ci/centos/mini-e2e

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Nov 18, 2020

CI passed Merging this one

@Madhu-1 Madhu-1 merged commit 83fbbd6 into ceph:release-v3.1 Nov 18, 2020
This was referenced Nov 18, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@ShyamsundarR ShyamsundarR ShyamsundarR approved these changes

Assignees
No one assigned
Labels
component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Madhu-1 @nixpanic @ShyamsundarR