util: store EnvVaultInsecure as string, not bool #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The configuration option `EnvVaultInsecure` is expected to be a string, not a boolean. By converting the bool back to a string (after verification), it is now possible to skip the certificate validation check by setting `vaultCAVerify: false` in the Vault configuration. Fixes: ceph#1852 Reported-by: Bryon Nevis <bryon.nevis@intel.com> Signed-off-by: Niels de Vos <ndevos@redhat.com>
nixpanic
added
bug
Madhu-1
approved these changes
Feb 2, 2021
Madhu-1
added
the
ready-to-merge
|
/retest ci/centos/upgrade-tests-cephfs |
It seems there is no automatic retry for installing the snapshot related components? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration option
EnvVaultInsecureis expected to be a string,not a boolean. By converting the bool back to a string (after
verification), it is now possible to skip the certificate validation
check by setting
vaultCAVerify: falsein the Vault configuration.Fixes: #1852
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)
/retest all: run this in case the CentOS CI failed to start/report any testprogress or results