Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove ok-to-test label after commenting #3671

Merged
merged 2 commits into from
Feb 20, 2023
Merged

ci: remove ok-to-test label after commenting #3671

merged 2 commits into from
Feb 20, 2023

Conversation

nixpanic
Copy link
Member

Once the comments have been added, the ok-to-test label can be removed. This makes it possible to simplify the Mergify configuration.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Feb 20, 2023
@nixpanic nixpanic requested a review from a team February 20, 2023 09:00
@mergify mergify bot added the component/testing Additional test cases or CI work label Feb 20, 2023
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Feb 20, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

Madhu-1
Madhu-1 previously approved these changes Feb 20, 2023
View reviewed changes
@nixpanic nixpanic marked this pull request as draft February 20, 2023 09:07
@nixpanic
Copy link
Member Author

Marking draft for now, didn't remove the label. Looking into a different approach.

@nixpanic nixpanic removed the ok-to-test Label to trigger E2E tests label Feb 20, 2023
@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Feb 20, 2023
@mergify mergify bot dismissed Madhu-1’s stale review February 20, 2023 09:10

Pull request has been modified.

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@nixpanic
ci: remove ok-to-test label after commenting
aa4d087 
Once the comments have been added, the `ok-to-test` label can be
removed. This makes it possible to simplify the Mergify configuration.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
@nixpanic
ci: do not let Mergify remove the ok-to-test label
5ffb9e0 
Sometimes Mergify removed the `ok-to-test` label before the Pull Request
Commentor action have been run. With the updated commentor action, the
`ok-to-test` label is removed after leaving comments. There is no need
for Mergify to remove the label anymore.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
@nixpanic nixpanic marked this pull request as ready for review February 20, 2023 09:14
@nixpanic nixpanic removed the ok-to-test Label to trigger E2E tests label Feb 20, 2023
@nixpanic
Copy link
Member Author

The action (adding the ok-to-test label) does not seem to trigger the modified workflow from this PR. It runs the workflow from the devel branch instead.

I'd appreciate to get this merged, and we'll check (and fix?) the automatic label removal after next PRs were used for testing.

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Feb 20, 2023
@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.23

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.24

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.25

@github-actions
Copy link

/test ci/centos/k8s-e2e-external-storage/1.26

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e-helm/k8s-1.26

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.23

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.24

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.25

@github-actions
Copy link

/test ci/centos/mini-e2e/k8s-1.26

@github-actions
Copy link

/test ci/centos/upgrade-tests-cephfs

@github-actions
Copy link

/test ci/centos/upgrade-tests-rbd

@nixpanic nixpanic requested a review from a team February 20, 2023 09:17
@nixpanic nixpanic removed the ok-to-test Label to trigger E2E tests label Feb 20, 2023
@nixpanic nixpanic requested a review from a team February 20, 2023 09:25
@nixpanic nixpanic merged commit 56c8f1e into ceph:devel Feb 20, 2023
@nixpanic nixpanic deleted the action/comment/remove-label branch February 20, 2023 10:10
@nixpanic nixpanic mentioned this pull request Feb 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@yati1998 yati1998 yati1998 approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixpanic @Madhu-1 @yati1998