Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: prevent Retest Workflow from running on forked repos #3883

Merged
merged 1 commit into from Jun 5, 2023
Merged

ci: prevent Retest Workflow from running on forked repos #3883

merged 1 commit into from Jun 5, 2023

Conversation

nixpanic
Copy link
Member

@nixpanic nixpanic commented Jun 5, 2023

Forked repositories contain the the .github/workflows/ directory, and therefore run all the GitHub Workflows located there. Some of the workflows need additional configuration, like providing access to the standard GITHUB_TOKEN. If the extra configuration is not done, the GitHub Workflow will fail, and the owner of the forked repository will receive regular notifications about that.

There is no need to run the "retest" workflow on forked repositories, so it can be skipped by default.

Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)
  • /retest all: run this in case the CentOS CI failed to start/report any test
    progress or results

@nixpanic nixpanic added ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Jun 5, 2023
@mergify mergify bot added the component/testing Additional test cases or CI work label Jun 5, 2023
karthik-us
karthik-us approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@karthik-us karthik-us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for this. Flooded with these failure notifications due to the retests on the forked repo.

riya-singhal31
riya-singhal31 approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@riya-singhal31 riya-singhal31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Niels, it will be good to have this!

@nixpanic
Copy link
Member Author

nixpanic commented Jun 5, 2023

+1 for this. Flooded with these failure notifications due to the retests on the forked repo.

Remember to re-sync the devel branch of your fork once this PR is merged!

@Mergifyio rebase

@nixpanic
Copy link
Member Author

nixpanic commented Jun 5, 2023

@Mergifyio rebase

@nixpanic
ci: prevent Retest Workflow from running on forked repos
873fe21 
Forked repositories contain the the `.github/workflows/` directory, and
therefore run all the GitHub Workflows located there. Some of the
workflows need additional configuration, like providing access to the
standard `GITHUB_TOKEN`. If the extra configuration is not done, the
GitHub Workflow will fail, and the owner of the forked repository will
receive regular notifications about that.

There is no need to run the "retest" workflow on forked repositories, so
it can be skipped by default.

Signed-off-by: Niels de Vos <ndevos@ibm.com>
@mergify
Copy link
Contributor

mergify bot commented Jun 5, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Jun 5, 2023
@nixpanic nixpanic force-pushed the workflows/limit-repository branch from 7ba8a51 to 873fe21 Compare June 5, 2023 08:26
@nixpanic nixpanic requested a review from a team June 5, 2023 08:26
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.24

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.24

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.25

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Jun 5, 2023
@mergify mergify bot merged commit 0e79135 into ceph:devel Jun 5, 2023
27 checks passed
@Rakshith-R
Copy link
Contributor

+1 for this. Flooded with these failure notifications due to the retests on the forked repo.

In general, its good to keep actions disabled in forks.
This setting is available in your fork url -> settings -> actions -> general.
Just in case others want to disable it.
image

@karthik-us
Copy link
Collaborator

In general, its good to keep actions disabled in forks. This setting is available in your fork url -> settings -> actions -> general. Just in case others want to disable it.

Thanks for the steps @Rakshith-R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthik-us karthik-us karthik-us approved these changes

@yati1998 yati1998 yati1998 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

Assignees
No one assigned
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/testing Additional test cases or CI work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nixpanic @ceph-csi-bot @Rakshith-R @karthik-us @yati1998 @riya-singhal31