cephfs: set Pool parameter to empty for Snapshot-backed volumes #4047
Conversation
| // Pool parameters is optional and only used to set 'pool_layout' arguement for | ||
| // subvolume and subvolume clone create commands. | ||
| // Setting this to emtpy since it is not used with Snapshot-backed volume. | ||
| vo.Pool = "" |
There was a problem hiding this comment.
Add an E2E testing to ensure it works and we will not break it in the future.
Rakshith-R
force-pushed
the
fix-cephfs-ro-pool
branch
2 times, most recently
from
4ec5e0a
to
c516125
Compare
|
/test ci/centos/mini-e2e/k8s-1.27 |
| // Pool parameters is optional and only used to set 'pool_layout' argument for | ||
| // subvolume and subvolume clone create commands. | ||
| // Setting this to empty since it is not used with Snapshot-backed volume. | ||
| vo.Pool = "" |
There was a problem hiding this comment.
Why should this not be the same as the pool of the original volume?
There was a problem hiding this comment.
Why should this not be the same as the pool of the original volume?
The original volume's pool is set only for create pvc/clone cmd as pool_layout (pool is retrieved directly from pv attributes) and is not saved anywhere and not used anywhere else.
The parentBackingSnapVolOpts here does not have its pool parameter set.
| if vo.Pool != "" { | ||
| return errors.New("cannot set pool for snapshot-backed volume") | ||
| } | ||
| // Pool parameters is optional and only used to set 'pool_layout' argument for |
There was a problem hiding this comment.
Pool parameters to Pool parameter
Rakshith-R
force-pushed
the
fix-cephfs-ro-pool
branch
from
c516125
to
18e85a0
Compare
|
@Mergifyio rebase |
Set VolumeOptions.Pool parameter to empty for Snapshot-backed volumes. This Pool parameter is optional and only used as 'pool-layout' parameter during subvolume and subvolume clone create request in cephcsi and not used for Snapshot-backed volume at all. It is not saved anywhere for use in subsequent operations after create too. Therefore, We can set it to empty and not error out. Signed-off-by: rakshith-r <rar@redhat.com>
✅ Branch has been successfully rebased |
nixpanic
force-pushed
the
fix-cephfs-ro-pool
branch
from
18e85a0
to
9692995
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.25 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/mini-e2e-helm/k8s-1.25 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.25 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
Describe what this PR does
Set VolumeOptions.Pool parameter to empty for Snapshot-backed volumes. This Pool parameter is optional and only used as 'pool_layout' parameter during subvolume and subvolume clone create request in cephcsi and not used for Snapshot-backed volume at all.
It is not saved anywhere for use in subsequent operations after create too. Therefore, We can set it to empty and not error out.
Refer: https://docs.ceph.com/en/latest/cephfs/fs-volumes/?highlight=pool_layout#fs-subvolumes
Resolves: #3820