Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy: use release repository for csi-resizer #4319

Merged
merged 1 commit into from Dec 14, 2023
Merged

deploy: use release repository for csi-resizer #4319

merged 1 commit into from Dec 14, 2023

Conversation

sebhoss
Copy link
Contributor

@sebhoss sebhoss commented Dec 14, 2023

Describe what this PR does

According to https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.9.2 registry.k8s.io/sig-storage/csi-resizer is the release repository for the csi-resizer image. I'm guessing that #4132 used the staging repo because the image tag was not yet pushed to the release repo.

Is there anything that requires special attention

I've verified that it is exactly the same image digest in both the staging and release repository, so this is basically a cosmetic change only.

Related issues

#4132 introduced the staging repo.

Future concerns

none afaics

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

iPraveenParihar
iPraveenParihar previously approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@iPraveenParihar iPraveenParihar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

nixpanic
nixpanic previously approved these changes Dec 14, 2023
View reviewed changes
@nixpanic nixpanic added component/deployment Helm chart, kubernetes templates and configuration Issues/PRs ci/skip/multi-arch-build skip building on multiple architectures labels Dec 14, 2023
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 14, 2023 •
edited

queue

🛑 The pull request has been removed from the queue default

The pull request #4319 has been manually updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 14, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 14, 2023
@sebhoss
deploy: use release repository for csi-resizer
a55ca65 
The image is now available in the release repository and can be fetched from
there instead of the staging repository.

Signed-off-by: Sebastian Hoß <seb@xn--ho-hia.de>
@sebhoss
Copy link
Contributor Author

sebhoss commented Dec 14, 2023

argh my commit message was too long - I've pushed an update that is within the 80 chars limit. Sorry for the inconvenience..

@mergify mergify bot dismissed stale reviews from nixpanic and iPraveenParihar December 14, 2023 12:02

Pull request has been modified.

@iPraveenParihar
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 14, 2023 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 14, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 14, 2023
@sebhoss
Copy link
Contributor Author

sebhoss commented Dec 14, 2023

There is one failure that says backend images not matching kubernetes resource count,image count 2 kubernetes resource count 1. The following two log outputs might be related to that:

E1214 13:34:52.156144       1 controller.go:957] error syncing claim "79836d37-932a-473f-b550-a22ee6bd3a31": failed to provision volume with StorageClass "csi-rbd-sc": rpc error: code = Internal desc = failed to create rbd image: rbd: ret=-17, File exists
  I1214 13:34:52.156278       1 event.go:298] Event(v1.ObjectReference{Kind:"PersistentVolumeClaim", Namespace:"rbd-9410", Name:"rbd-pvc", UID:"79836d37-932a-473f-b550-a22ee6bd3a31", APIVersion:"v1", ResourceVersion:"5206", FieldPath:""}): type: 'Warning' reason: 'ProvisioningFailed' failed to provision volume with StorageClass "csi-rbd-sc": rpc error: code = Internal desc = failed to create rbd image: rbd: ret=-17, File exists

Dec 14 13:35:17.381: INFO: At 2023-12-14 13:34:26 +0000 UTC - event for vault-init-job: {job-controller } FailedCreate: Error creating: pods "vault-init-job-" is forbidden: error looking up service account cephcsi-e2e-447985d7/rbd-csi-vault-token-review: serviceaccount "rbd-csi-vault-token-review" not found

A successful run from yesterday does not have these errors in its log, however I'm not sure whether these errors are due to the change in this PR or caused by something else. @iPraveenParihar @nixpanic can you take another look?

@iPraveenParihar
Copy link
Contributor

/test ci/centos/mini-e2e/k8s-1.26

@mergify mergify bot merged commit b25a02e into ceph:devel Dec 14, 2023
35 checks passed
@Rakshith-R Rakshith-R added the backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch label Dec 15, 2023
@Rakshith-R
Copy link
Contributor

@Mergifyio refresh

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot mentioned this pull request Dec 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nixpanic nixpanic nixpanic approved these changes

@iPraveenParihar iPraveenParihar iPraveenParihar approved these changes

Assignees
No one assigned
Labels
backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch ci/skip/multi-arch-build skip building on multiple architectures component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sebhoss @nixpanic @ceph-csi-bot @iPraveenParihar @Rakshith-R