Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: log repication RequestID #4429

Merged
merged 1 commit into from Feb 13, 2024
Merged

util: log repication RequestID #4429

merged 1 commit into from Feb 13, 2024

Conversation

Madhu-1
Copy link
Collaborator

@Madhu-1 Madhu-1 commented Feb 13, 2024

currently, we are not logging the RequestID for the replication RPC calls. This PR adds the replication case to the getReqID
function.

@Madhu-1 Madhu-1 requested review from a team February 13, 2024 08:39
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 13, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Feb 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 13, 2024
@Madhu-1 Madhu-1 added bug Something isn't working backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch labels Feb 13, 2024
@nixpanic
Copy link
Member

@Madhu-1 do we have e2e tests for this, maybe it is not needed to run them?

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 13, 2024

@nixpanic IMHO not required as we dont have E2E for RDR.

@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Feb 13, 2024

Lets run one test to ensure nothing breaks after that we can add skip flag

@nixpanic
Copy link
Member

@Mergifyio rebase

@Madhu-1 @nixpanic
util: log repication RequestID
e1a1c7c 
currently we are not logging the RequestID
for the replication RPC calls. This PR
adds the replication case to the getReqID
function.

Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

/test ci/centos/k8s-e2e-external-storage/1.29

@nixpanic nixpanic added the ci/skip/e2e skip running e2e CI jobs label Feb 13, 2024
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 13, 2024 •
edited

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 4e296bf

@nixpanic nixpanic added the ok-to-test Label to trigger E2E tests label Feb 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Feb 13, 2024
@mergify mergify bot merged commit 4e296bf into ceph:devel Feb 13, 2024
41 checks passed
@mergify mergify bot mentioned this pull request Feb 13, 2024
Merged
@Madhu-1 Madhu-1 mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yati1998 yati1998 yati1998 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees
No one assigned
Labels
backport-to-release-v3.10 Label to backport from devel to release-v3.10 branch bug Something isn't working ci/skip/e2e skip running e2e CI jobs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Madhu-1 @ceph-csi-bot @nixpanic @yati1998 @Rakshith-R