Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cephfs: upgrade fscrypt version to fix concurrency issue #4609

Merged
merged 1 commit into from
May 13, 2024
Merged

cephfs: upgrade fscrypt version to fix concurrency issue #4609

merged 1 commit into from
May 13, 2024

Conversation

NymanRobin
Copy link
Contributor

In older versions of fscrypt there is a race condition when multiple encrypted cephfs instances are deployed simultaneously.
This PR upgrades the fscrypt version to the latest version that contains a fix to the concurrency issue, used the commit sha as we cannot know when the next official release will happen from fscrypt side.

This PR fixes: #4592

@mergify mergify bot added component/cephfs Issues related to CephFS bug Something isn't working labels May 8, 2024
Rakshith-R
Rakshith-R previously approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@Rakshith-R Rakshith-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Rakshith-R Rakshith-R requested a review from a team May 8, 2024 10:12
Madhu-1
Madhu-1 previously approved these changes May 8, 2024
View reviewed changes
@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 8, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 8, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request.
@Nordix needs to authorize modification on its head branch.

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 8, 2024

rebase

❌ Pull request can't be updated with latest base branch changes

Mergify needs the author permission to update the base branch of the pull request. @Nordix needs to authorize modification on its head branch.

@NymanRobin can you please check this one?

@Madhu-1 Madhu-1 added the backport-to-release-v3.11 Label to backport from devel to release-v3.11 branch label May 8, 2024
@NymanRobin
Copy link
Contributor Author

Sure, I will check @Madhu-1

@NymanRobin
cephfs: upgrade fscrypt version to fix concurrency issue
81c01fb 
In older versions of fscrypt there is a race condition
when multiple encrypted cephfs instances are deployed
simultaneously.

Signed-off-by: NymanRobin <robin.nyman@est.tech>
@mergify mergify bot dismissed stale reviews from Madhu-1 and Rakshith-R May 8, 2024 13:00

Pull request has been modified.

@NymanRobin
Copy link
Contributor Author

I did a manual rebase, do you think that will do it? @Madhu-1

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 8, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 8, 2024

queue

🟠 Waiting for conditions to match

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by>=2 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success=Configuration changed

@Madhu-1
Copy link
Collaborator

Madhu-1 commented May 8, 2024

I did a manual rebase, do you think that will do it? @Madhu-1

i triggered bot, lets see how it goes :)

@Madhu-1 Madhu-1 requested a review from Rakshith-R May 8, 2024 13:02
@Madhu-1 Madhu-1 requested a review from a team May 8, 2024 13:02
@Rakshith-R
Copy link
Contributor

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented May 13, 2024 •
edited

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label May 13, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label May 13, 2024
@NymanRobin
Copy link
Contributor Author

NymanRobin commented May 13, 2024 •
edited

Looks like there was a failure related to the network in one of tests? Would it be possible to retrigger it?

Error: Error downloading packages:
  Curl error (7): Couldn't connect to server for http://mirrorlist.centos.org/?release=8-stream&arch=x86_64&repo=AppStream&infra=ec2 [Failed to connect to mirrorlist.centos.org port 80: Connection refused]
script returned exit code 1

EDIT: Seems there was also another test failure that I am not exactly sure of what caused it

@Rakshith-R
Copy link
Contributor

@iPraveenParihar please check and restart the tests

@iPraveenParihar
Copy link
Contributor

/retest ci/centos/mini-e2e/k8s-1.27

@iPraveenParihar
Copy link
Contributor

/retest ci/centos/mini-e2e/k8s-1.28

@mergify mergify bot merged commit 3073409 into ceph:devel May 13, 2024
39 checks passed
@mergify mergify bot mentioned this pull request May 13, 2024
Closed
@NymanRobin NymanRobin mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@Rakshith-R Rakshith-R Rakshith-R approved these changes

Assignees

@iPraveenParihar iPraveenParihar

Labels
backport-to-release-v3.11 Label to backport from devel to release-v3.11 branch bug Something isn't working component/cephfs Issues related to CephFS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrency issue when provisioning multiple encrypted CephFS instances
5 participants
@NymanRobin @Madhu-1 @Rakshith-R @ceph-csi-bot @iPraveenParihar