ensure priorities for custom repos as well #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Deza <alfredo.deza@inktank.com>
|
Tests passed for this pull request. |
| name = kw.get('name', '%s repo' % reponame) | ||
| enabled = kw.get('enabled', 1) | ||
| gpgcheck = kw.get('gpgcheck', 1) | ||
| name = kw.pop('name', '%s repo' % reponame) |
There was a problem hiding this comment.
these where changed from get to pop so that we could re-use **kw and not have duplicate keywords.
|
looks good, tests on RHEL6.5 |
ChristinaMeno
added a commit
that referenced
this pull request
Oct 3, 2014
ensure priorities for custom repos as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, custom repos where getting overridden even if they had
piority=1because ceph-deploy was not passing that option and was not installing the plugin.This enforces that behavior but only when the priority flag is set.
Reference ticket: http://tracker.ceph.com/issues/9645