RM-7505 Add support for Arch Linux #461
Conversation
hosts: add arch based on fedora and add detection for distro. util: add pacman package manager and archlinux default package. install: add distro detection and package selection
|
Can one of the admins verify this patch? |
| hostname = distro.conn.hostname | ||
| LOG = logging.getLogger(hostname) | ||
|
|
||
| # I need to stop and disable services prior package removal |
There was a problem hiding this comment.
this reads like a packaging problem on Arch's side. It is the package itself that should have rules that take care of this. I guess this doesn't happen here because you have encountered this?
There was a problem hiding this comment.
Exactly, Arch packages don't start nor stop services, neither handle enabling/disabling.
There was a problem hiding this comment.
Would you prefer to notify the user, instead of starting and enabling services?
|
BTW, I can help you with the testing and maintaining of this for Arch Linux, I have a productive Arch Linux server so I will use this for a long time. |
There was a problem hiding this comment.
This looks OK to me. I am not excited about adding support for non-ceph supported systems though. I'm OK with merging this as-is
/cc @vasukulkarni
|
No objections as well, but It will be nice to throw Warning message during install, something like "Arch is not a supported distro and is for experimental use" or something ( can be added in install.py). We can merge this after that. |
|
@vasukulkarni we don't do that for all the other distros that we don't support, so I am -1 on adding warnings just for Arch. |
|
@alfredodeza yep that is fair!, we have other distro's without warning message, yet some point we should add the warning based on ceph tested distro's but is a different issue. |
With the help of a friend, we added support for Arch Linux.
We tested it several times on different machines and VMs to make sure it works as expected.
I was specially careful on not changing current functionality.