Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: fixed int regex matcher to require the full string #78

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

dillaman
Copy link

@dillaman dillaman commented Oct 9, 2018

This prevents an exception when trying to incorrectly convert an IP
address to an integer.

Signed-off-by: Jason Dillaman dillaman@redhat.com

This prevents an exception when trying to incorrectly convert an IP
address to an integer.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Copy link
Contributor

@mikechristie mikechristie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh dang, my regex skills are coming in handy. LGTM.

@dillaman dillaman merged commit ccca57d into master Oct 10, 2018
@dillaman dillaman deleted the wip-int-setting-regex branch October 10, 2018 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants