Add option to force deletion of unreachable gw #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 5, 2019 15:07
We currently remove the gateway from the config on the gateway we want to remove. If the gw is down permanently this creates the problem that we cannot delete the gw unless you re-create it. This patch adds a force option, so gwcli and api users can tell rbd-target-api on the local node to just update the config there and ignore the dead gw. Signed-off-by: Mike Christie <mchristi@redhat.com>
We could be doing a remove_child while the thread that updates the state is accessing children in GatewayGroup->refresh which will cause a crash. This has the gw deletion function grab the thread lock while updating children. Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Mike Christie <mchristi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first patch fixes the issue where if a gw is dead, we can't delete it because we normally update the config on the node we are updating. The other patches fix some bugs/issues found while testing it.