Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter discovery controller async notifications #324

Closed
caroav opened this issue Nov 19, 2023 · 0 comments · Fixed by #367
Closed

Filter discovery controller async notifications #324

caroav opened this issue Nov 19, 2023 · 0 comments · Fixed by #367
Assignees
@gbregman
Labels
bug Something isn't working Discovery Controller productization

Comments

@caroav
Copy link
Collaborator

caroav commented Nov 19, 2023

The Discovery controller is currently trying to send an Async notification on every OMAP state change. This is not right. It should only send notifications in one of the following changes:

  1. Subsystem add/remove.
  2. Listener add/remove.

For all the rest of the changes, no Async event should be send from the Discovery controller.
@gbregman gbregman assigned gbregman and unassigned leonidc Jan 7, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 14, 2024
@gbregman
Only send discovery async notifications fro subsystem and listener up…
f0670be 
…dates.

Fixes ceph#324

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
@gbregman gbregman mentioned this issue Jan 14, 2024
Merged
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 14, 2024
@gbregman
Only send discovery service async notifications for subsystem and lis…
69f7218 
…tener updates.

Fixes ceph#324

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbregman gbregman

Labels
bug Something isn't working Discovery Controller productization
Projects
NVMe-oF
Archived in project
Milestone
No milestone
3 participants
@leonidc @caroav @gbregman