[nvme-cli] port number should be mandatory in listener delete command

[sunilkumarn417]

Currently, listener delete command works without port number i.e, assumes default port 4420. But CLI should be successful only if port number provided, and not consider the default port number 4420.

[root@ceph-1sunilkumar-ol18l6-node5 cephuser]# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 --format json listener list -n nqn.2016-06.io.spdk:test_cli
{
    "error_message": "Success",
    "listeners": [
        {
            "gateway_name": "client.nvmeof.rbd.ceph-1sunilkumar-ol18l6-node5.mnoqha",
            "trtype": "TCP",
            "adrfam": "ipv4",
            "traddr": "10.0.211.32",
            "trsvcid": 4420
        },
        {
            "gateway_name": "client.nvmeof.rbd.ceph-1sunilkumar-ol18l6-node5.mnoqha",
            "trtype": "TCP",
            "adrfam": "ipv4",
            "traddr": "10.0.211.32",
            "trsvcid": 4421
        }
    ],
    "status": 0
}

[root@ceph-1sunilkumar-ol18l6-node5 cephuser]# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 --format json listener del -n nqn.2016-06.io.spdk:test_cli -g client.nvmeof.rbd.ceph-1sunilkumar-ol18l6-node5.mnoqha -a 10.0.211.32
{
    "error_message": "Success",
    "status": 0
}

[root@ceph-1sunilkumar-ol18l6-node5 cephuser]# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 --format json listener list -n nqn.2016-06.io.spdk:test_cli
{
    "error_message": "Success",
    "listeners": [
        {
            "gateway_name": "client.nvmeof.rbd.ceph-1sunilkumar-ol18l6-node5.mnoqha",
            "trtype": "TCP",
            "adrfam": "ipv4",
            "traddr": "10.0.211.32",
            "trsvcid": 4421
        }
    ],
    "status": 0
}

[root@ceph-1sunilkumar-ol18l6-node5 cephuser]# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 --format json listener del -n nqn.2016-06.io.spdk:test_cli -g client.nvmeof.rbd.ceph-1sunilkumar-ol18l6-node5.mnoqha -a 10.0.211.32
{
    "status": 32602,
    "error_message": "Failure deleting listener 10.0.211.32:4420 from nqn.2016-06.io.spdk:test_cli: Invalid parameters"
}

[root@ceph-1sunilkumar-ol18l6-node5 cephuser]# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 --format json listener list -n nqn.2016-06.io.spdk:test_cli
{
    "error_message": "Success",
    "listeners": [
        {
            "gateway_name": "client.nvmeof.rbd.ceph-1sunilkumar-ol18l6-node5.mnoqha",
            "trtype": "TCP",
            "adrfam": "ipv4",
            "traddr": "10.0.211.32",
            "trsvcid": 4421
        }
    ],
    "status": 0
}

[gbregman]

@sunilkumarn417 I will change the trsvcid argument to be mandatory on "listener del" command, it will still default to 4420 on "listener add" command. Notice that using 4420 as a default value for deleting a listener is not a new thing. It was the same in the old CLI.