Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nvme-cli] Internal error while add/deleting host if host argument id not provided #361

Closed
sunilkumarn417 opened this issue Jan 12, 2024 · 0 comments · Fixed by #363
Closed
Assignees
Labels
bug Something isn't working CLI

Comments

@sunilkumarn417
Copy link

sunilkumarn417 commented Jan 12, 2024

Internal error is noticed when host added/deleted without "--host" option.

# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 host add -n nqn.2016-06.io.spdk:test_cli 
Failure adding host  to nqn.2016-06.io.spdk:test_cli: Internal error

[2024-01-11 13:09:59.303537] subsystem.c:  85:nvmf_valid_nqn: *ERROR*: Invalid NQN "": length 0 < min 11
ERROR:control.grpc:Failure adding host  to nqn.2016-06.io.spdk:test_cli:
request:
{
  "nqn": "nqn.2016-06.io.spdk:test_cli",
  "host": "",
  "method": "nvmf_subsystem_add_host",
  "req_id": 16
}
Got JSON-RPC error response
response:
{
  "code": -32603,
  "message": "Internal error"
}

# podman run quay.io/ceph/nvmeof-cli:v0.0.7 --server-address 10.0.211.32 --server-port 5500 host del -n nqn.2016-06.io.spdk:test_cli
Failure removing host  access from nqn.2016-06.io.spdk:test_cli: Internal error

INFO:control.grpc:Received request to remove host  access from nqn.2016-06.io.spdk:test_cli, context: <grpc._server._Context object at 0x7fc1dbda97c0>
ERROR:control.grpc:Failure removing host  access from nqn.2016-06.io.spdk:test_cli:
request:
{
  "nqn": "nqn.2016-06.io.spdk:test_cli",
  "host": "",
  "method": "nvmf_subsystem_remove_host",
  "req_id": 21
}
Got JSON-RPC error response
response:
{
  "code": -32603,
  "message": "Internal error"
}
DEBUG:control.state:omap_key removed: host_nqn.2016-06.io.spdk:test_cli_
DEBUG:control.state:Update complete.
ERROR:control.grpc:Error persisting host  access removal:
'host_nqn.2016-06.io.spdk:test_cli_'
@sunilkumarn417 sunilkumarn417 added bug Something isn't working CLI labels Jan 12, 2024
@sunilkumarn417 sunilkumarn417 changed the title [nvme-cli] Internal error while adding host if host argument id not provided [nvme-cli] Internal error while add/deleting host if host argument id not provided Jan 12, 2024
@caroav caroav assigned gbregman and unassigned caroav Jan 14, 2024
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 14, 2024
…commands.

Fixes ceph#361

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLI
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants