Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check NQN validity in CLI #364

Closed
gbregman opened this issue Jan 14, 2024 · 2 comments · Fixed by #381
Closed

Check NQN validity in CLI #364

gbregman opened this issue Jan 14, 2024 · 2 comments · Fixed by #381
Assignees

Comments

@gbregman
Copy link
Contributor

We use NQNs in most of the CLI commands. In case the NQN is too short or too long we would get an error from SPDK. But this error just says "internal error". We can easily check for this in the CLI side and issue a more specific error.

@gbregman gbregman self-assigned this Jan 14, 2024
@pcuzner
Copy link
Contributor

pcuzner commented Jan 14, 2024

@gbregman will you be validating the format of the nqn for the subsystem and hosts?

@gbregman
Copy link
Contributor Author

@pcuzner , yes, as is done in the SPDK code. The same validation function is used for subsystem and host NQNs. I'm not sure I'll implement the entire validation code but at least obvious things, like string length, etc.

gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 18, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 18, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 18, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 18, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 19, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 21, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 21, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
gbregman added a commit to gbregman/ceph-nvmeof that referenced this issue Jan 21, 2024
Fixes ceph#364

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants