Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change subsystem creation to enable HA by default #537

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Change subsystem creation to enable HA by default #537

merged 1 commit into from
Mar 27, 2024

Conversation

gbregman
Copy link
Contributor

Fixes #536

@gbregman gbregman self-assigned this Mar 27, 2024
caroav
caroav reviewed Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@caroav caroav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how do you define that enable-ha will be true by default? I think we should not expose any option right now, not to work with ha.

@gbregman gbregman force-pushed the devel branch 2 times, most recently from dfc81fc to 6811b3f Compare March 27, 2024 11:05
@gbregman
Change subsystem creation to enable HA by default
a4147d6 
Fixes ceph#536

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
@gbregman gbregman merged commit 77e8470 into ceph:devel Mar 27, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caroav caroav caroav approved these changes

Assignees

@gbregman gbregman

Labels
None yet
Projects
NVMe-oF
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change the subsystem creation default to enable HA
2 participants
@gbregman @caroav