RGW: Zipper - zonegroup, placement tier #45623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved |
cbodley
reviewed
Apr 7, 2022
cbodley
reviewed
Apr 7, 2022
cbodley
reviewed
Apr 7, 2022
dang
force-pushed
the
wip-dang-zipper-objctx
branch
from
8ae0438
to
b0586de
Compare
|
jenkins test api |
cbodley
reviewed
Apr 12, 2022
dang
force-pushed
the
wip-dang-zipper-objctx
branch
from
b0586de
to
6d446ae
Compare
|
This fixes dbstore, which I inadvertently broke. |
cbodley
reviewed
Apr 20, 2022
Add ZoneGroup and PlacementTier to the Zipper API. This cleaned up a lot of issues in the Module branch. In addition, add cloud transition. Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
dang
force-pushed
the
wip-dang-zipper-objctx
branch
from
6d446ae
to
92252d2
Compare
|
@cbodley Is this good to go now? |
cbodley
approved these changes
Apr 26, 2022
Comment on lines
+669
to
+677
| std::unique_ptr<RGWRealmReloader> reloader; | ||
| std::unique_ptr<RGWPeriodPusher> pusher; | ||
| std::unique_ptr<RGWFrontendPauser> pauser; | ||
| std::unique_ptr<RGWRealmWatcher> realm_watcher; | ||
| if (store->get_name() == "rados") { | ||
| // add a watcher to respond to realm configuration changes | ||
| pusher = std::make_unique<RGWPeriodPusher>(&dp, store, null_yield); | ||
| pauser = std::make_unique<RGWFrontendPauser>(fes, implicit_tenant_context, pusher.get()); | ||
| reloader = std::make_unique<RGWRealmReloader>(store, service_map_meta, pauser.get()); |
There was a problem hiding this comment.
i like std::optional for conditional or deferred initialization, but this looks correct now 👍
(here during startup, it doesn't make much difference whether or not we allocate for unique_ptr)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ZoneGroup and PlacementTier to the Zipper API. This cleaned up a
lot of issues in the Module branch.
In addition, add cloud transition.
Signed-off-by: Daniel Gryniewicz dang@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows