pacific: mgr/dashboard: BDD approach for the dashboard cephadm e2e #46529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files under the directory cypress/integration/common/* will contain common specs which can be used on all the .feature files. We can change the common directory to cypress/integration/* from the package.json, but if we do that now then we'll need to take care of all the absolute import in that path. So for now at least that's not a good choice. The bug in the cypress-browserify-preprocessor which doesn't allow to take our tsconfig.json file forced me to go with relative imports rather than the absolute import. We'll need to wait for this to be fixed before changing all our tests to BDD. Fixes: https://tracker.ceph.com/issues/54224 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit 79f8545)
nizamial09
requested review from
nSedrickm and
Pegonzal
and removed request for
a team
Its a regression introduced by BDD testing ceph@79f8545 Fixes: https://tracker.ceph.com/issues/54990 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit 4a34762)
Cypress sometimes fail to register the click and that causes the deselect/select to not happen properly. Deselecting the row immediately after performing the action makes it pass from cypress. Fixes: https://tracker.ceph.com/issues/55741 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit dcf0445)
|
qa run 1 passed and 1 failed. failure doesn't seem related though |
Save the mgr container logs of cephadm inside a folder and later on archive it and get it as an artifact on the cephadm dashboard e2e jobs Fixes: https://tracker.ceph.com/issues/55247 Signed-off-by: Nizamudeen A <nia@redhat.com> (cherry picked from commit d74defb)
aaSharma14
approved these changes
Jun 23, 2022
Sarthak0702
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport tracker: https://tracker.ceph.com/issues/54623,
backport tracker: https://tracker.ceph.com/issues/56036, https://tracker.ceph.com/issues/55453
backport of #44835
parent tracker: https://tracker.ceph.com/issues/54224, https://tracker.ceph.com/issues/55741, https://tracker.ceph.com/issues/55247
this backport was staged using ceph-backport.sh version 16.0.0.6848
find the latest version at https://github.com/ceph/ceph/blob/main/src/script/ceph-backport.sh