Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients: Add new client playbook #25

Merged
merged 1 commit into from Aug 19, 2021
Merged

Conversation

pcuzner
Copy link
Contributor

@pcuzner pcuzner commented Aug 16, 2021

Playbook handles the distribution of conf and keyring
to a group of ceph clients. The expectation is that the
ceph admin has created at least the appropriate keyring
on the admin node for this playbook to distribute. If the
playbook is called without a conf, it will generate and
distribute a minimal conf

Signed-off-by: Paul Cuzner pcuzner@redhat.com

@pcuzner pcuzner requested a review from guits August 16, 2021 03:05
@pcuzner
Copy link
Contributor Author

pcuzner commented Aug 16, 2021

@guits can you take a look at this and see if this would address the client gap that cephadm currently has?

Copy link
Collaborator

@guits guits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really want to store data on the 'local' node like this?

ceph-defaults/defaults/main.yml Outdated Show resolved Hide resolved
cephadm-clients.yml Show resolved Hide resolved
cephadm-clients.yml Outdated Show resolved Hide resolved
cephadm-clients.yml Outdated Show resolved Hide resolved
cephadm-clients.yml Outdated Show resolved Hide resolved
cephadm-clients.yml Show resolved Hide resolved
@guits
Copy link
Collaborator

guits commented Aug 16, 2021

@pcuzner As far as I remember, it was decided that cephadm itself should handle this functionality, I'm not sure cephadm-ansible is the best place to address that gap.

Having to use an external tool in order to handle this doesn't seem ideal, it might lead to inconsistencies issues, eg:
each time you make a change such as adding a new monitor, it forces you to rerun that playbook to make all your client nodes aware of it whereas if cephadm would handle this functionality, I would expect it to do it automatically for you.

@pcuzner pcuzner requested a review from guits August 16, 2021 21:12
@pcuzner pcuzner marked this pull request as ready for review August 18, 2021 02:00
Playbook handles the distribution of conf and keyring
to a group of ceph clients. The expectation is that the
ceph admin has created at least the appropriate keyring
on the admin node for this playbook to distribute. If the
playbook is called without a conf, it will generate and
distribute a minimal conf

Signed-off-by: Paul Cuzner <pcuzner@redhat.com>
@pcuzner
Copy link
Contributor Author

pcuzner commented Aug 19, 2021

@guits updated and squashed

@guits guits merged commit 133dcde into ceph:devel Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants